From fa76ac2a4ad7ee9f1955ca26e73e6e886bc21f32 Mon Sep 17 00:00:00 2001 From: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Date: Tue, 21 Jul 2026 10:49:33 -0700 Subject: [PATCH] Update patch set 2 Patch Set 2: Code-Review+1 (1 comment) Patch-set: 2 Label: Code-Review=+1, 117c04a3befb0dfcaa8cb24864bea7e290b4a1be Label: Commit-Queue=0, 81501571ddf4c2528bf4b996a95795535d938edb --- 8e3bb9d16f1d9d3e35b905f47fd775371f7b55a5 | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/8e3bb9d16f1d9d3e35b905f47fd775371f7b55a5 b/8e3bb9d16f1d9d3e35b905f47fd775371f7b55a5 index 77a7e8e8a..0ca843f77 100644 --- a/8e3bb9d16f1d9d3e35b905f47fd775371f7b55a5 +++ b/8e3bb9d16f1d9d3e35b905f47fd775371f7b55a5 @@ -1,5 +1,22 @@ { "comments": [ + { + "unresolved": true, + "key": { + "uuid": "e955db88_e18f2de9", + "filename": "source/row_common.cc", + "patchSetId": 1 + }, + "lineNbr": 3316, + "author": { + "id": 1115898 + }, + "writtenOn": "2026-07-21T17:49:33Z", + "side": 1, + "message": "If this code is taken as verbatim, this adds an add or lea.\n\nThe original code would use \u0027indexed+offset\u0027 addressing which is best for Intel.\n\nAn alternative would be use 2 pointers. Which can do the ptr +\u003d 4 \u0027for free\u0027 on arm.\nAlthough post increment doesnt take an instruction, it does take a microop, so on high end arm this isnt faster.\n\nIsn\u0027t the original index by an int (stride) a clean way to index pointers?", + "revId": "8e3bb9d16f1d9d3e35b905f47fd775371f7b55a5", + "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" + }, { "unresolved": false, "key": {