From fceff1326283dede33c4f0d183524e57d7bc4bb5 Mon Sep 17 00:00:00 2001 From: Youssef Elghareeb Date: Tue, 18 Jan 2022 14:51:33 +0100 Subject: [PATCH] Add submit requirements for project libyuv/libyuv Rules for creating new submit requirements are as follows: * We don't create submit requirements for labels that are not blocking. * For labels that do not define any values, we assume they are overriding a label definition from the parent project (i.e. to ignore this label in the child project), hence we create a non-applicable submit requirement for them. * For other blocking labels, we create a corresponding submit requirement for them. Note that for the 'Code-Review' requirement we also set the overrideIf condition to 'Bot-Commit=+1' since this requirement is currently enforced from All-Projects rules.pl [1]. When this change is submitted, the Code-Review SR in this change will be authoritative for the project and needs to behave in the same way as was previously configured. [1] https://chromium.googlesource.com/All-Projects/+/5ddd22e7537172878280dc2b47373251e842dda7/rules.pl#7 Change-Id: I5b8e7b6fb9b28c5266f94f97d5c81e273a72872c Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/3398373 Reviewed-by: Josip Sokcevic --- project.config | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/project.config b/project.config index 31587a49e..b60e76490 100644 --- a/project.config +++ b/project.config @@ -45,3 +45,13 @@ submit = group libyuv-scoped@luci-project-accounts.iam.gserviceaccount.com [access "refs/heads/master"] exclusiveGroupPermissions = push submit +[submit-requirement "Code-Review"] + description = Submit requirement for the 'Code-Review' label + submittableIf = label:Code-Review=MAX,user=non_uploader -label:Code-Review=MIN + overrideIf = label:Bot-Commit=+1 + canOverrideInChildProjects = true +[submit-requirement "Verified"] + description = Submit requirement for the 'Verified' label + applicableIf = is:false + submittableIf = is:true + canOverrideInChildProjects = true