39 Commits

Author SHA1 Message Date
Victor Hugo Vianna Silva
4825d9b29e Use default xcode version in libyuv
Following crrev.com/c/7171485, libyuv should be able to rely on
the default xcode version of the bots.

Bug: 461757070
Change-Id: Iecc34bb0b0476b61be1d9dfd51904396913c85f4
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7177782
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-11-24 07:54:14 -08:00
Victor Hugo Vianna Silva
068c9f2f64 Upgrade linux bots from ubuntu 22.04 to 24.04
Bug: 459541007
Change-Id: I0ff7ecb4400f82ef7cff93ec98fe16b47ded062b
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7132084
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
2025-11-12 17:34:13 -08:00
Victor Hugo Vianna Silva
1f62f14950 Update xcode in bots (3rd attempt)
The .cfg file in https://crrev.com/c/7043382 wasn't up-to-date for
some reason. I verified this CL indeed updates xcode in the iOS
bot. mac_asan is still broken for now.
- led get-builder "libyuv/try/ios_arm64_rel" > config.json
- Edit config.json to include the snippet below in its properties.
- cat config.json | led launch

https://ci.chromium.org/ui/p/libyuv/builders/ci.shadow/iOS%20ARM64%20Release/1/overview

```
"$depot_tools/osx_sdk": {
  "sdk_version": "17a324"
},
```

Bug: 448679376
Change-Id: Ie15e6164246611a5a1c06357307be512da0ff902
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7046681
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
2025-10-16 14:28:05 -07:00
Victor Hugo Vianna Silva
a5acc0bea9 Update xcode in bots (2nd attempt)
Turns out there are 2 ways to specify an xcode version on the bots.
https://crrev.com/c/7037174 used a way that differs from the one
currently in place in the bot recipe [1]. See thread [2] for more
details. This CL reverts most xcode changes from the original CL
and adopts an approach similar to https://crrev.com/i/8594830
instead.

I would have preferred to verify this CL works ahead of landing
with led, but I don't have permission [3]. No-Try: True is added
because mac_asan is busted https://crrev.com/c/7045106.

[1] https://source.chromium.org/chromium/infra/infra_superproject/+/main:build/recipes/recipes/libyuv/libyuv.py
[2] https://chat.google.com/room/AAAAzEuhg8A/S-r4vJCVnLY
[3] https://chat.google.com/room/AAAAzEuhg8A/S-r4vJCVnLY

No-Try: True
Bug: 448679376
Change-Id: I24609c820491f5bd93052687af8989f63172b144
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7043382
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-10-16 12:39:27 -07:00
Victor Hugo Vianna Silva
28ebe5d0b0 Fix led failing due to service account disallowed
Follow-up to https://crrev.com/c/7046060.
Comparing the files below, we see the issue's root cause.

https://source.chromium.org/chromium/chromium/src/+/main:third_party/libyuv/infra/config/cr-buildbucket.cfg;l=607-620;drc=110e00ea9693e9feed3f6bb49cf7a9497440bca1
https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/infra/config/generated/cr-buildbucket.cfg;l=2143-2154;drc=722572ab69816657492c1155dad7f99e3e2629ea

Bug: None
Change-Id: Iaf339950db4e8b414719057ae81ba5b850f0aace
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7050097
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2025-10-16 10:41:52 -07:00
Victor Hugo Vianna Silva
110e00ea96 Allow use of led via http://go/ciba
Users who have the "Chrome Build Access" in go/ciba can now use the
`led` CLI on libyuv bots. No-Try because the mac-asan bot is busted.

I will use this to test the CL below ahead of submission.
https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7043382

No-Try: True
Change-Id: I33b488406f342fac4ff33d02e2c70cef2e50233c
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7046060
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-10-16 05:57:31 -07:00
Victor Hugo Vianna Silva
613393324f Fix CQ not finding Mac-15 x86_64 bots
https://crrev.com/c/7037174 took effect but now CQ finds no Mac-15
x86_64 bots [1]. Fix by switching to arm64.
This change lists "No-Try: True" because CQ is busted.

[1] https://ci.chromium.org/ui/p/libyuv/builders/try/ios_arm64/3589/infra

No-Try: True
Bug: chromium:448679376
Change-Id: I6b77ce004f8cbbe0ea5c434edd140dd1ece6a152
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7041203
Reviewed-by: Ben Weiss <bweiss@google.com>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Justin Green <greenjustin@google.com>
Reviewed-by: Wan-Teh Chang <wtc@google.com>
2025-10-14 10:22:16 -07:00
Victor Hugo Vianna Silva
69046a8ab0 Update Mac and Xcode version in bots
Bug: 448679376
Change-Id: I077cd31073889afe0519195a8c459570bc95e4a8
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7037174
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Christoffer Dewerin <jansson@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
2025-10-14 05:18:54 -07:00
Takuto Ikuta
c00b83884e infra/config: Remove luci.recipes.use_python3 experiment
Python3 is used by default in recipes now and this config is not
necessary anymore.

Bug: 440235171
Change-Id: Ia7d2d54ca3afe25b43e8a1636d08507f709f0966
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6888293
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2025-09-02 01:08:51 -07:00
Junji Watanabe
20b1d84ec8 infra: Remove reclient properties from infra config
This completes the Siso migration for libyuv.

No-Try: true
Bug: 412968361
Change-Id: I0b823d7a0b6895bfd26dcdd0cdae9eb665f02f11
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6606659
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Christoffer Dewerin <jansson@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
2025-06-02 00:54:25 -07:00
Junji Watanabe
f7392e01c1 infra: Add $build/siso properties to libyuv builders
This CL switches libyuv builders from Ninja to Siso. Reclient will still
be used.

https://crrev.com/c/6605972 is the corresponding recipe change.

No-Try: true
Bug: chromium:412968361
Change-Id: I6ba063d0aa954185284a44d0b353278d71953e4b
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6589372
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Christoffer Dewerin <jansson@chromium.org>
2025-06-02 00:07:24 -07:00
Jeremy Leconte
2caaf190bb Revert "Remove linux_tsan2 bot from CQ."
This reverts commit 4115e118e880c7089babeb96d449ca30a8a91a2b.

Reason for revert: fixed with the chromium roll

Original change's description:
> Remove linux_tsan2 bot from CQ.
>
> No-Try: True
> Bug: b/384912633
> Change-Id: Ic8a0f50dfd328df8770fbadfe5be51cc40232ee9
> Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6105834
> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>

Bug: b/384912633
Change-Id: I1b40e659af1d3253c89b20f18385777189812e56
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6162535
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-01-09 00:26:58 -08:00
Björn Terelius
dd216e765c Remove linux_msan from CQ
Bug:libyuv:388428508
No-Try: true
Change-Id: I808653d40e1d3cc8ed94358c633bd97e98441c9d
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6158985
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-01-08 08:13:33 -08:00
Jeremy Leconte
f54aac5279 Remove .vpython.
No-Try: True
Bug: None
Change-Id: I4c1b901831d25acd33e766b9f4cbbe1db9d38ab2
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6111091
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
2024-12-19 08:35:12 -08:00
Jeremy Leconte
e01109dd9b Add constraints to the luci buckets.
Goal is to be able to run led jobs, current error is:
constraints for libyuv:try not found

Bug: b/384862261
Change-Id: Ia88f2de7a4068baf151f94ea8cf708983939d11a
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6105837
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2024-12-18 12:09:19 -08:00
Jeremy Leconte
4115e118e8 Remove linux_tsan2 bot from CQ.
No-Try: True
Bug: b/384912633
Change-Id: Ic8a0f50dfd328df8770fbadfe5be51cc40232ee9
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6105834
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
2024-12-18 08:16:20 -08:00
Björn Terelius
37e88ecc68 Update pylintrc to a pep-8 like style
In particular, this requires reformatting
- autoroller/
- PRESUBMIT.py
- infra/config/PRESUBMIT.py
- get_landmines.py
- download_vs_toolchain.py
as well as some manual fixes.

This CL is preparation to updating the autoroller so that we can roll DEPS from chromium.

No-Try: True
Bug: libyuv:358992053
Change-Id: I090a09c6fa61beff2427a0537bca371f0839fa3e
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6105550
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
2024-12-18 05:38:56 -08:00
Ben Pastene
8e18fc93c8 infra: Move libyuv ci/try jobs from Ubuntu-18.04 to Ubuntu-22.04
These are the last remaining jobs on the last remaining bionic pools.
Moving these over should let the bionic flex pool finally be decommed.

All of chrome/chromium has been on Ubuntu-22.04 for months now. So
hopefully this is transparent for libyuv.

Bug: chromium:40255350
Change-Id: Ib361fb8a2c33357df4d26bd58334190e4a8914e4
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/5550963
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2024-05-21 15:55:24 +00:00
Takuto Ikuta
c60323de17 infra/config: remove goma property
goma property is not necessary anymore as libyuv builders use reclient
now.

Bug: b/239908030
Change-Id: I8bcf25e4c047569c2272b0f9fdfb5eb936698955
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/4787829
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2023-08-17 06:06:53 +00:00
Mirko Bonadei
47731743bf Use walleye instead of bullhead
Bug: None
Change-Id: Iaa17f73afca4db09e6c176b7771c02dfbcea6cb0
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/4580128
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
2023-06-01 15:43:00 +00:00
Mirko Bonadei
06bd62e9b1 Move from Mac-10.15 to Mac-12
Bug: chromium:1273556
Change-Id: Idaf61210ac9028ac664fde5c369d3de3fc092819
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/4577786
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
2023-06-01 12:12:34 +00:00
Junji Watanabe
7ccf31d3b6 [infra] Allow project-libyuv-admins group to trigger LED tasks
"role/swarming.taskTriggerer" gives "swarming.tasks.createInRealm" permission.
https://source.chromium.org/chromium/infra/infra/+/main:luci/appengine/auth_service/realms/permissions.py;l=114;drc=36516367cd70f195935ffd933d939e770e3b2c65

This fixes the auth error in "led launch".
http://screen/58TYKnHALbRUQKb

Bug: b:255217089
Change-Id: Idbfc06e7ad8a94caac9bfd1fe473c60d6e4addf6
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/3990134
Reviewed-by: Christoffer Jansson <jansson@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
2022-11-01 12:40:22 +00:00
Junji Watanabe
ab386814ac [infra] Set reclient properties to libyuv builders
libyuv project will use the same RBE backend with webrtc project.

Bug: b:239908030
Change-Id: I1c852e57bce2fcef159d930c36f210939b4f3432
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/3990126
Reviewed-by: Christoffer Jansson <jansson@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
2022-10-31 08:46:12 +00:00
Christoffer Jansson
ba77d34307 add jansson@google.com to infra owners to cover when Mirko is OOO
Bug: None
Change-Id: I5c829bb52b8e2c5f99b1b6b926fcaeab4ddca115
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/3990603
Commit-Queue: Magnus Jedvert <magjed@chromium.org>
Reviewed-by: Magnus Jedvert <magjed@chromium.org>
2022-10-28 09:46:02 +00:00
Fabrice de Gans
73968bd946 [code-health] Migrate presubmit to python3
This also fixes a presubmit warning by formatting a gni file.

No-Try: True
Bug: 942720
Change-Id: I50bfc993282c5546753ba2be466ba06a5ff9cc6a
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/3902395
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2022-09-26 21:57:55 +00:00
Jeremy Leconte
a1a52d5364 Copy infra/config branch in infra/config folder of the main branch.
Bug: chromium:1159728
Change-Id: I0af72d5ab2e7d2e134af5152fec935b1d821cdbf
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/3545227
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
2022-03-23 13:15:03 +00:00
Oleh Prypin
7ce50764c5 Remove infra/config directory because cq.cfg has been moved
https://chromium-review.googlesource.com/1437407 made it so that this cq.cfg has no effect.

Bug: chromium:916292
Change-Id: I2c35b11405836a54112611a9decd33bd21e1d4c3
Reviewed-on: https://chromium-review.googlesource.com/c/1442211
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2019-01-30 01:01:22 +00:00
Oleh Prypin
97ea700d55 Remove linux_memcheck from commit queue
It seems hopelessly broken, as no other project is using/maintaining it anymore

No-Try: True
Change-Id: I2affd8e68a9aecdd2de2cd10fee11afb2f1a390a
Reviewed-on: https://chromium-review.googlesource.com/c/1301502
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
2018-10-29 07:21:06 +00:00
Eric Foo
8c51cc6ddc Remove Android MIPs BB builder
Bug:869249
Change-Id: Ida001cb05e27b6a064d1b3a4ec51cc7bb537845b
Reviewed-on: https://chromium-review.googlesource.com/1179372
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Eric Foo <efoo@chromium.org>
2018-08-17 18:33:22 +00:00
Eric Foo
fdd975ae87 Flip mirrored Windows LUCI builders to prod
No-try:True
Bug:869249
Change-Id: Iaf4d0aecc5ac63e4369e840a99aea2e7fa1f3d6c
Reviewed-on: https://chromium-review.googlesource.com/1173140
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
2018-08-16 09:40:09 +00:00
Patrik Höglund
6b70a8c5f1 Try reordering buckets to work around gerrit tryjob plugin bug
With several buckets, it appears the gerrit tryjobs plugin only
displays the first bucket. In that case we want to display the main
UCI bucket rather than the win stragglers in buildbot.

No-try: True
Tbr: fbarchard@chromium.org
Bug: chromium:869249
Change-Id: I50dcbf668d29becbe493601be8b9db089de78b85
Reviewed-on: https://chromium-review.googlesource.com/1170688
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
2018-08-10 08:36:57 +00:00
Patrik Höglund
6e62ff3495 Fix missing brace + incorrect nesting in cq.cfg.
try_job can't be repeated, but buckets can. I think this does what
Ryan intended.

Also add a presubmit so this doesn't happen again.

No-try because CQ is broken, and even if it weren't nothing
would catch errors in cq.cfq directly.

No-try: True
Tbr: fbarchard@chromium.org
Bug: 869249
Change-Id: If84685f93275f5af691fc3fef77881156930b726
Reviewed-on: https://chromium-review.googlesource.com/1169820
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
2018-08-10 08:20:15 +00:00
Ryan Tseng
791e7be466 [cq.cfg] Flip all builders (except windows) to LUCI
All builders look WAI now, so flipping.
In particular, the android bots have been migrated in place to LUCI,
so the buildbot varients should no longer work.

No-Try: True
Bug:869249
Change-Id: Iab96cab5d92a106df67fc2458150c0dc93b77fc4
Reviewed-on: https://chromium-review.googlesource.com/1169593
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
2018-08-10 06:37:38 +00:00
Andrii Shyshkalov
15d48f1e83 Remove Rietveld CQ config.
Rietveld CQ has already been disabled and is no longer supoorted.

TBR=phoglund@chromium.org

No-Try: True
Bug: chromium:770592
Change-Id: I2679e9193dfb5ec751bdc76d35fe5d835b44bd0a
Reviewed-on: https://chromium-review.googlesource.com/714302
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
2017-10-12 06:43:30 +00:00
Patrik Höglund
b7b5374263 kjellander -> phoglund in OWNERS
R=kjellander@chromium.org

Bug:libyuv:741
Change-Id: I6bc18e94ec82e00518f34695cf3b97deed82c76d
Reviewed-on: https://chromium-review.googlesource.com/699996
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
2017-10-09 11:40:28 +00:00
Henrik Kjellander
9c2748c7d0 CQ: Remove android_clang as default trybot
Android has been building with Clang by default for quite some
time since the NDK has deprecated GCC. The bot will go away shortly.

TBR=fbarchard@chromium.org
NOTRY=True

Change-Id: Ie4d80daf7f91f55aa4a27089e725960c0646e051
Reviewed-on: https://chromium-review.googlesource.com/654997
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
2017-09-07 11:48:22 +00:00
Henrik Kjellander
b97406775c Remove duplicated bot linux_msan in cq.cfg.
BUG=None
TBR=fbarchard@chromium.org

Change-Id: Id665a052c0f164ca58ee317ff2cb065c6a67da77
Reviewed-on: https://chromium-review.googlesource.com/521523
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
2017-06-01 17:58:16 +00:00
Andrii Shyshkalov
22c12037c5 CQ config: add gerrit CQAbility verifier.
Goal is to ensure that unreviewed and untrusted code isn't sent through
CQ to try bots, by accident or through malicious intent.

R=kjellander@google.com
BUG=chromium:692613
NOTRY=True

Change-Id: If10d778b9c9866593a4c6c36216ed0e1c12fa1d5
Reviewed-on: https://chromium-review.googlesource.com/443546
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
2017-02-27 11:55:04 +00:00
Aaron Gable
dbee5e2a9f Add a CQ to libyuv
This adds a commit queue for libyuv. The set of bots triggered
is the same as the set previously specified in PRESUBMIT.py. This
has two advantages over the current setup:
a) You get nice features in Gerrit (like a dry run button); and
b) You get a CQ!

Change-Id: I006e8480fa7238d9e7a0cfa0a932ddabcd71f511
Reviewed-on: https://chromium-review.googlesource.com/430917
Reviewed-by: Frank Barchard <fbarchard@google.com>
2017-01-20 19:41:35 +00:00