Update patch set 2

Patch Set 2: Commit-Queue+2

(1 comment)

Patch-set: 2
Label: Commit-Queue=+2, dc693813713bf2b3d12c7fdc4f646443aa30bb6a

0390a71c4773d8e9f885c272ebd01d4e3a5843eb

@@ -0,0 +1,137 @@
+{
+  "comments": [],
+  "submitRequirementResults": [
+    {
+      "submitRequirement": {
+        "name": "Code-Review",
+        "description": {
+          "value": "If the author is a libyuv committer, code review is required from one other committer. Otherwise, code review is required from two committers."
+        },
+        "applicabilityExpression": {},
+        "submittabilityExpression": {
+          "expressionString": "((uploaderin:cria/project-libyuv-committers AND label:Code-Review\u003dMAX,user\u003dnon_uploader) OR label:Code-Review\u003dMAX,count\u003e\u003d2) AND -label:Code-Review\u003dMIN"
+        },
+        "overrideExpression": {
+          "value": {
+            "expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
+          }
+        },
+        "allowOverrideInChildProjects": true
+      },
+      "applicabilityExpressionResult": {},
+      "submittabilityExpressionResult": {
+        "value": {"expression":{"expressionString":"((uploaderin:cria/project-libyuv-committers AND label:Code-Review=MAX,user=non_uploader) OR label:Code-Review=MAX,count>=2) AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX,user=non_uploader","uploaderin:cria/project-libyuv-committers","label:Code-Review=MAX,count>=2"],"failingAtoms":["label:Code-Review=MIN"]}
+      },
+      "overrideExpressionResult": {
+        "value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Bot-Commit=+1","label:Code-Review=MIN"]}
+      },
+      "patchSetCommitId": "0390a71c4773d8e9f885c272ebd01d4e3a5843eb",
+      "legacy": {
+        "value": false
+      },
+      "forced": {},
+      "hidden": {}
+    },
+    {
+      "submitRequirement": {
+        "name": "No-Unresolved-Comments",
+        "description": {
+          "value": "Changes that have unresolved comments are not submittable. Unless overridden with Unresolved-Comment-Reason: \u003creason\u003e line in change message."
+        },
+        "applicabilityExpression": {
+          "value": {
+            "expressionString": "has:unresolved"
+          }
+        },
+        "submittabilityExpression": {
+          "expressionString": "-has:unresolved"
+        },
+        "overrideExpression": {
+          "value": {
+            "expressionString": "message:\"^.*Unresolved-Comment-Reason:.*\""
+          }
+        },
+        "allowOverrideInChildProjects": false
+      },
+      "applicabilityExpressionResult": {
+        "value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"]}
+      },
+      "submittabilityExpressionResult": {
+        "value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
+      },
+      "overrideExpressionResult": {
+        "value": {"expression":{"expressionString":"message:\"^.*Unresolved-Comment-Reason:.*\""},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
+      },
+      "patchSetCommitId": "0390a71c4773d8e9f885c272ebd01d4e3a5843eb",
+      "legacy": {
+        "value": false
+      },
+      "forced": {},
+      "hidden": {}
+    },
+    {
+      "submitRequirement": {
+        "name": "Review-Enforcement",
+        "description": {
+          "value": "Two Google employees must approve the change. Uploading the change or voting positively on Code-Review count as approval. Using a trusted device is required, see go/gerrit-onboarding#review-enforcement."
+        },
+        "applicabilityExpression": {
+          "value": {
+            "expressionString": "is:review-enforced_gerrit"
+          }
+        },
+        "submittabilityExpression": {
+          "expressionString": "is:review-enforcement-satisfied_gerrit"
+        },
+        "overrideExpression": {},
+        "allowOverrideInChildProjects": false
+      },
+      "applicabilityExpressionResult": {
+        "value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[]}
+      },
+      "submittabilityExpressionResult": {
+        "value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:review-enforcement-satisfied_gerrit"]}
+      },
+      "overrideExpressionResult": {},
+      "patchSetCommitId": "0390a71c4773d8e9f885c272ebd01d4e3a5843eb",
+      "legacy": {
+        "value": false
+      },
+      "forced": {},
+      "hidden": {
+        "value": true
+      }
+    },
+    {
+      "submitRequirement": {
+        "name": "Verified",
+        "description": {
+          "value": "Submit requirement for the \u0027Verified\u0027 label"
+        },
+        "applicabilityExpression": {
+          "value": {
+            "expressionString": "is:false"
+          }
+        },
+        "submittabilityExpression": {
+          "expressionString": "is:true"
+        },
+        "overrideExpression": {},
+        "allowOverrideInChildProjects": true
+      },
+      "applicabilityExpressionResult": {
+        "value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"]}
+      },
+      "submittabilityExpressionResult": {
+        "value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
+      },
+      "overrideExpressionResult": {},
+      "patchSetCommitId": "0390a71c4773d8e9f885c272ebd01d4e3a5843eb",
+      "legacy": {
+        "value": false
+      },
+      "forced": {},
+      "hidden": {}
+    }
+  ]
+}

a9d3be7762e54ce3127ab6f7d867f6b87e77f954

@@ -0,0 +1,75 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "94b976a0_09c92a33",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 1
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1178490
+      },
+      "writtenOn": "2024-12-13T15:17:04Z",
+      "side": 1,
+      "message": "The problem on iOS looks real:\n\n```\n[69/95] CXX obj/libyuv_sve/row_sve.o\nFAILED: obj/libyuv_sve/row_sve.o\n../../buildtools/reclient/rewrapper -cfg\u003d../../buildtools/reclient_cfgs/chromium-browser-clang/rewrapper_mac.cfg -exec_root\u003d/Volumes/Work/s/w/...(too long)\nIn file included from ../../source/row_sve.cc:11:\n../../include/libyuv/row_sve.h:321:52: error: expected function body after function declarator\n321 |                                         int width) STREAMING_COMPATIBLE {\n|                                                    ^\n../../source/row_sve.cc:89:3: error: use of undeclared identifier \u0027I400ToARGBRow_SVE_SC\u0027; did you mean \u0027I400ToARGBRow_SVE2\u0027?\n89 |   I400ToARGBRow_SVE_SC(src_y, dst_argb, yuvconstants, width);\n|   ^~~~~~~~~~~~~~~~~~~~\n|   I400ToARGBRow_SVE2\n../../source/row_sve.cc:85:6: note: \u0027I400ToARGBRow_SVE2\u0027 declared here\n85 | void I400ToARGBRow_SVE2(const uint8_t* src_y,\n|      ^\n../../source/row_sve.cc:98:3: error: use of undeclared identifier \u0027I422ToARGBRow_SVE_SC\u0027; did you mean \u0027I422ToARGBRow_SVE2\u0027?\n```\n\nCan you take a look before landing?",
+      "revId": "a9d3be7762e54ce3127ab6f7d867f6b87e77f954",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "64efdb14_ab4b02e7",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 1
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1001562
+      },
+      "writtenOn": "2024-12-13T15:52:30Z",
+      "side": 1,
+      "message": "This compilation error (on iOS and macOS with arm64 CPUs) is not introduced by this CL. It will be fixed by my other CL: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6087913",
+      "parentUuid": "94b976a0_09c92a33",
+      "revId": "a9d3be7762e54ce3127ab6f7d867f6b87e77f954",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "f969952f_eb916ed0",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 1
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1001562
+      },
+      "writtenOn": "2024-12-13T15:55:32Z",
+      "side": 1,
+      "message": "I meant George Steed\u0027s other CL. These are not my CLs. Sorry!",
+      "parentUuid": "64efdb14_ab4b02e7",
+      "revId": "a9d3be7762e54ce3127ab6f7d867f6b87e77f954",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "47246f41_516dede8",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 1
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1178490
+      },
+      "writtenOn": "2024-12-13T16:01:12Z",
+      "side": 1,
+      "message": "Thanks for taking a look.\n\nI added No-Try.",
+      "parentUuid": "f969952f_eb916ed0",
+      "revId": "a9d3be7762e54ce3127ab6f7d867f6b87e77f954",
+      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
+    }
+  ]
+}