Compare commits

...

3 Commits

Author SHA1 Message Date
Gerrit User 1115898
9d66face85 Create patch set 4
Change has been successfully rebased and submitted as a5acc0bea90b6f3ca6a0a23a453b9be04cd5f478

Patch-set: 4
Patch-set-description: Rebase
Subject: Update xcode in bots (2nd attempt)
Status: merged
Commit: a5acc0bea90b6f3ca6a0a23a453b9be04cd5f478
Tag: autogenerated:gerrit:merged
Groups: 69d391362a8c98ec72970a774fecceb4cc7f6ffb
Label: Code-Review=+1, 800b540e22c340fe1622d563e4501242d306d808
Label: Code-Review=+1, 9a398782452c233692a415572e0b401d36c4cd34 Gerrit User 1178490 <1178490@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Code-Review=+1, bd87c8cf9157721a6bcfd3947474a75b8b9cef3e Gerrit User 1425877 <1425877@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: SUBM=+1, 36306b8b59889ffb874e00edad7770158d160816
Submission-id: 7043382
Submitted-with: OK
Submitted-with: Rule-Name: gerrit~DefaultSubmitRule
Submitted-with: MAY: Auto-Submit
Submitted-with: MAY: Code-Coverage
Submitted-with: MAY: Code-Review: Gerrit User 1178490 <1178490@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Submitted-with: MAY: Commit-Queue
Submitted-with: MAY: Feels
Submitted-with: MAY: Bot-Commit
Submitted-with: MAY: Owners-Override
Submitted-with: MAY: Lint
Submitted-with: OK
Submitted-with: Rule-Name: Code-Owners
Base: 28ebe5d0b0c8e30fa1a9c60f03e411086c00ad3d
Ours: c122501a853b4ed385886185c9b6e15e9c9c5bbe
Theirs: 2b4453d46faebcad72d744d763a4e3b1e97d338d
Merge-Strategy: simple-two-way-in-core
Contains-Conflicts: false
Attention: {"person_ident":"Gerrit User 1339017 \u003c1339017@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"Change was submitted"}
2025-10-16 12:39:27 -07:00
Gerrit User 1115898
dd5262e047 Update patch set 3
Patch-set: 3
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: SUBM=+1, 6e3028fe6c890deb5ee3ee8686f7442a2cc0d953
2025-10-16 12:39:27 -07:00
Gerrit User 1115898
2970f17881 Update patch set 3
Patch Set 3:

(1 comment)

Patch-set: 3
2025-10-16 11:40:52 -07:00

View File

@ -16,6 +16,198 @@
"message": "Rebased. Still want to land this?",
"revId": "c122501a853b4ed385886185c9b6e15e9c9c5bbe",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "bde8bf2d_b3aaa00a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 1115898
},
"writtenOn": "2025-10-16T18:40:52Z",
"side": 1,
"message": "btw the mac asan bot is currently broken\nhttps://chromium-review.googlesource.com/c/libyuv/libyuv/+/7045953",
"revId": "c122501a853b4ed385886185c9b6e15e9c9c5bbe",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
],
"submitRequirementResults": [
{
"submitRequirement": {
"name": "Admin-Approval",
"description": {
"value": "Changes to refs/meta/config must be approved by a git admin."
},
"applicabilityExpression": {
"value": {
"expressionString": "branch:refs/meta/config"
}
},
"submittabilityExpression": {
"expressionString": "(uploaderin:mdb/chrome-git-admins OR label:Code-Review\u003dMAX,group\u003dmdb/chrome-git-admins) AND label:Code-Review\u003dMAX,user\u003dnon_uploader AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {
"value": {
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
}
},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"branch:refs/meta/config"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"(uploaderin:mdb/chrome-git-admins OR label:Code-Review=MAX,group=mdb/chrome-git-admins) AND label:Code-Review=MAX,user=non_uploader AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"patchSetCommitId": "c122501a853b4ed385886185c9b6e15e9c9c5bbe",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Code-Review",
"description": {
"value": "If the author is a libyuv committer, code review is required from one other committer. Otherwise, code review is required from two committers."
},
"applicabilityExpression": {
"value": {
"expressionString": "-branch:refs/meta/config"
}
},
"submittabilityExpression": {
"expressionString": "((uploaderin:cria/project-libyuv-committers AND label:Code-Review\u003dMAX,user\u003dnon_uploader) OR label:Code-Review\u003dMAX,count\u003e\u003d2) AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {
"value": {
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
}
},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"-branch:refs/meta/config"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"((uploaderin:cria/project-libyuv-committers AND label:Code-Review=MAX,user=non_uploader) OR label:Code-Review=MAX,count>=2) AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX,user=non_uploader","uploaderin:cria/project-libyuv-committers","label:Code-Review=MAX,count>=2"],"failingAtoms":["label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Code-Review=MIN":"","label:Code-Review=MAX,user=non_uploader":"","uploaderin:cria/project-libyuv-committers":"","label:Code-Review=MAX,count>=2":""}}}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Bot-Commit=+1","label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Bot-Commit=+1":"","label:Code-Review=MIN":""}}}
},
"patchSetCommitId": "c122501a853b4ed385886185c9b6e15e9c9c5bbe",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "No-Unresolved-Comments",
"description": {
"value": "Changes that have unresolved comments are not submittable. Unless overridden with Unresolved-Comment-Reason: \u003creason\u003e line in change message."
},
"applicabilityExpression": {
"value": {
"expressionString": "has:unresolved"
}
},
"submittabilityExpression": {
"expressionString": "-has:unresolved"
},
"overrideExpression": {
"value": {
"expressionString": "message:\"^.*Unresolved-Comment-Reason:.*\""
}
},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"],"atomExplanations":{"value":{"has:unresolved":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"message:\"^.*Unresolved-Comment-Reason:.*\""},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"patchSetCommitId": "c122501a853b4ed385886185c9b6e15e9c9c5bbe",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Review-Enforcement",
"description": {
"value": "Two trusted contributors must approve the change. Uploading the change or voting positively on Code-Review count as approval. For Google employees, using a trusted device is required (go/gerrit-onboarding#review-enforcement). For non-Google employees, ReAuth is required (https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gerrit_reauth.md)."
},
"applicabilityExpression": {
"value": {
"expressionString": "is:review-enforced_gerrit"
}
},
"submittabilityExpression": {
"expressionString": "is:review-enforcement-satisfied_gerrit"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforced_gerrit":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforcement-satisfied_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforcement-satisfied_gerrit":"Required approval count satisfied"}}}
},
"overrideExpressionResult": {},
"patchSetCommitId": "c122501a853b4ed385886185c9b6e15e9c9c5bbe",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Verified",
"description": {
"value": "Submit requirement for the \u0027Verified\u0027 label"
},
"applicabilityExpression": {
"value": {
"expressionString": "is:false"
}
},
"submittabilityExpression": {
"expressionString": "is:true"
},
"overrideExpression": {},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"],"atomExplanations":{"value":{"is:false":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {},
"patchSetCommitId": "c122501a853b4ed385886185c9b6e15e9c9c5bbe",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
}
]
}