mirror of
https://chromium.googlesource.com/libyuv/libyuv
synced 2025-12-06 08:46:47 +08:00
Compare commits
15 Commits
e285a624b7
...
676287b30f
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
676287b30f | ||
|
|
04968f47d6 | ||
|
|
526f02b65d | ||
|
|
8718b90e3a | ||
|
|
cfae6f48b5 | ||
|
|
3f90c8935b | ||
|
|
cbe277406d | ||
|
|
c37b82b174 | ||
|
|
1bcfd7584e | ||
|
|
d94b5aeb31 | ||
|
|
71cab522f7 | ||
|
|
7f4b41bc28 | ||
|
|
8faf11d6a8 | ||
|
|
09dbfa698b | ||
|
|
41921e8f14 |
196
5606b306cde3724da06037145d6fa799d9385861
Normal file
196
5606b306cde3724da06037145d6fa799d9385861
Normal file
@ -0,0 +1,196 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "ca99283c_1bdee08a",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1115898
|
||||
},
|
||||
"writtenOn": "2025-10-27T21:20:06Z",
|
||||
"side": 1,
|
||||
"message": "fyi an llvm/mca test for the instruction https://godbolt.org/z/zeGTchrxn",
|
||||
"revId": "5606b306cde3724da06037145d6fa799d9385861",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
}
|
||||
],
|
||||
"submitRequirementResults": [
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Admin-Approval",
|
||||
"description": {
|
||||
"value": "Changes to refs/meta/config must be approved by a git admin."
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "branch:refs/meta/config"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "(uploaderin:mdb/chrome-git-admins OR label:Code-Review\u003dMAX,group\u003dmdb/chrome-git-admins) AND label:Code-Review\u003dMAX,user\u003dnon_uploader AND -label:Code-Review\u003dMIN"
|
||||
},
|
||||
"overrideExpression": {
|
||||
"value": {
|
||||
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
|
||||
}
|
||||
},
|
||||
"allowOverrideInChildProjects": false
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"branch:refs/meta/config"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"(uploaderin:mdb/chrome-git-admins OR label:Code-Review=MAX,group=mdb/chrome-git-admins) AND label:Code-Review=MAX,user=non_uploader AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
||||
},
|
||||
"overrideExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
||||
},
|
||||
"patchSetCommitId": "5606b306cde3724da06037145d6fa799d9385861",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Code-Review",
|
||||
"description": {
|
||||
"value": "If the author is a libyuv committer, code review is required from one other committer. Otherwise, code review is required from two committers."
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "-branch:refs/meta/config"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "((uploaderin:cria/project-libyuv-committers AND label:Code-Review\u003dMAX,user\u003dnon_uploader) OR label:Code-Review\u003dMAX,count\u003e\u003d2) AND -label:Code-Review\u003dMIN"
|
||||
},
|
||||
"overrideExpression": {
|
||||
"value": {
|
||||
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
|
||||
}
|
||||
},
|
||||
"allowOverrideInChildProjects": true
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"-branch:refs/meta/config"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"((uploaderin:cria/project-libyuv-committers AND label:Code-Review=MAX,user=non_uploader) OR label:Code-Review=MAX,count>=2) AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX,user=non_uploader","uploaderin:cria/project-libyuv-committers"],"failingAtoms":["label:Code-Review=MIN","label:Code-Review=MAX,count>=2"],"atomExplanations":{"value":{"label:Code-Review=MIN":"","label:Code-Review=MAX,user=non_uploader":"","uploaderin:cria/project-libyuv-committers":"","label:Code-Review=MAX,count>=2":""}}}
|
||||
},
|
||||
"overrideExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Bot-Commit=+1","label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Bot-Commit=+1":"","label:Code-Review=MIN":""}}}
|
||||
},
|
||||
"patchSetCommitId": "5606b306cde3724da06037145d6fa799d9385861",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "No-Unresolved-Comments",
|
||||
"description": {
|
||||
"value": "Changes that have unresolved comments are not submittable. Unless overridden with Unresolved-Comment-Reason: \u003creason\u003e line in change message."
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "has:unresolved"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "-has:unresolved"
|
||||
},
|
||||
"overrideExpression": {
|
||||
"value": {
|
||||
"expressionString": "message:\"^.*Unresolved-Comment-Reason:.*\""
|
||||
}
|
||||
},
|
||||
"allowOverrideInChildProjects": false
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"],"atomExplanations":{"value":{"has:unresolved":""}}}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
||||
},
|
||||
"overrideExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"message:\"^.*Unresolved-Comment-Reason:.*\""},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
||||
},
|
||||
"patchSetCommitId": "5606b306cde3724da06037145d6fa799d9385861",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Review-Enforcement",
|
||||
"description": {
|
||||
"value": "Two trusted contributors must approve the change. Uploading the change or voting positively on Code-Review count as approval. For Google employees, using a trusted device is required (http://go/gerrit-onboarding#review-enforcement). For non-Google employees, ReAuth is required (https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gerrit_reauth.md)."
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "is:review-enforced_gerrit"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "is:review-enforcement-satisfied_gerrit"
|
||||
},
|
||||
"overrideExpression": {},
|
||||
"allowOverrideInChildProjects": false
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforced_gerrit":""}}}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforcement-satisfied_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforcement-satisfied_gerrit":"Required approval count satisfied"}}}
|
||||
},
|
||||
"overrideExpressionResult": {},
|
||||
"patchSetCommitId": "5606b306cde3724da06037145d6fa799d9385861",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Verified",
|
||||
"description": {
|
||||
"value": "Submit requirement for the \u0027Verified\u0027 label"
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "is:false"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "is:true"
|
||||
},
|
||||
"overrideExpression": {},
|
||||
"allowOverrideInChildProjects": true
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"],"atomExplanations":{"value":{"is:false":""}}}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
||||
},
|
||||
"overrideExpressionResult": {},
|
||||
"patchSetCommitId": "5606b306cde3724da06037145d6fa799d9385861",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
}
|
||||
]
|
||||
}
|
||||
92
f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7
Normal file
92
f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7
Normal file
@ -0,0 +1,92 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f9625f5d_b220ec9e",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1115898
|
||||
},
|
||||
"writtenOn": "2025-10-27T20:45:51Z",
|
||||
"side": 1,
|
||||
"message": "f32mm detect for arm. tested on android/chrome emulator",
|
||||
"revId": "f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "b690f4b0_5b9f9cf5",
|
||||
"filename": "include/libyuv/cpu_id.h",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 33,
|
||||
"author": {
|
||||
"id": 1001562
|
||||
},
|
||||
"writtenOn": "2025-10-27T21:12:51Z",
|
||||
"side": 1,
|
||||
"message": "I found that include/libyuv/cpu_id.h is a public header. For backward compatibility we should not change the values of the constants `kCpuHasSME` and `kCpuHasSME2`.\n\nAre `kCpuHasSME` and `kCpuHasSME2` part of libyuv\u0027s public API? Or are they actually internal constants and just exposed in a public header unintentionally?",
|
||||
"revId": "f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "111fabb9_770d575a",
|
||||
"filename": "include/libyuv/cpu_id.h",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 33,
|
||||
"author": {
|
||||
"id": 1115898
|
||||
},
|
||||
"writtenOn": "2025-10-27T21:18:04Z",
|
||||
"side": 1,
|
||||
"message": "Done. The names of the constants (kCpuHasSME) are public, but the user is expected to compile against the named constants, not bypass them. We\u0027ve done renumbering in the past, several times. \nBut in this case, its easy to avoid, so done",
|
||||
"parentUuid": "b690f4b0_5b9f9cf5",
|
||||
"revId": "f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "cac9b512_d95b80ef",
|
||||
"filename": "include/libyuv/cpu_id.h",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 33,
|
||||
"author": {
|
||||
"id": 1001562
|
||||
},
|
||||
"writtenOn": "2025-10-27T21:23:23Z",
|
||||
"side": 1,
|
||||
"message": "Thanks for the reply. This means libyuv doesn\u0027t provide binary compatibility. (Binary compatibility means an application that uses the libyuv shared library (.so) does not need to be recompiled when a new version of the libyuv shared library is installed.)",
|
||||
"parentUuid": "111fabb9_770d575a",
|
||||
"revId": "f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "30d002a7_e820eb80",
|
||||
"filename": "include/libyuv/cpu_id.h",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 33,
|
||||
"author": {
|
||||
"id": 1115898
|
||||
},
|
||||
"writtenOn": "2025-10-27T21:29:56Z",
|
||||
"side": 1,
|
||||
"message": "It wasnt really on my radar, but I did notice hwcaps attempts to be binary compatible. I dont know if we should make any promises, but lets try not to break binary compatibility.\n\nthe yuv to rgb \u0027matrix\u0027 structures would be the main binary format. If a user defined one and the format changed, it would break.\n\ncpus come and go, so its mainly been about keeping tidy and less than 32 bits. But tidiness can be deferred until a cleanup is necessary",
|
||||
"parentUuid": "cac9b512_d95b80ef",
|
||||
"revId": "f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
x
Reference in New Issue
Block a user