{ "comments": [ { "unresolved": false, "key": { "uuid": "cfc69b32_37195463", "filename": "/PATCHSET_LEVEL", "patchSetId": 5 }, "lineNbr": 0, "author": { "id": 1115898 }, "writtenOn": "2025-10-16T21:45:12Z", "side": 1, "message": "rebased. I dont have an easy way to test this, so let me know if you want to go ahead", "revId": "07f34d97711b91c3eb148d8c0e6955a0d5fb40d9", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" }, { "unresolved": false, "key": { "uuid": "6b8b7ea0_31511aba", "filename": "/PATCHSET_LEVEL", "patchSetId": 5 }, "lineNbr": 0, "author": { "id": 3711818 }, "writtenOn": "2025-10-17T02:27:22Z", "side": 1, "message": "Thanks.I want to go ahead, I believe that more and more people will use RVV with intrinsic\u003e\u003dv1.0", "parentUuid": "cfc69b32_37195463", "revId": "07f34d97711b91c3eb148d8c0e6955a0d5fb40d9", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" }, { "unresolved": true, "key": { "uuid": "bfdf1a19_33b9ad86", "filename": "/PATCHSET_LEVEL", "patchSetId": 5 }, "lineNbr": 0, "author": { "id": 3711818 }, "writtenOn": "2025-10-17T02:32:00Z", "side": 1, "message": "Is there anything I can do to make the RVV test a bit easier?", "parentUuid": "6b8b7ea0_31511aba", "revId": "07f34d97711b91c3eb148d8c0e6955a0d5fb40d9", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" }, { "unresolved": false, "key": { "uuid": "754c0ecd_d352f972", "filename": "/PATCHSET_LEVEL", "patchSetId": 5 }, "lineNbr": 0, "author": { "id": 1115898 }, "writtenOn": "2025-10-17T18:29:23Z", "side": 1, "message": "I managed to test your CL... looks good\n[----------] Global test environment tear-down\n[\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d] 3474 tests from 8 test suites ran. (415439 ms total)\n[ PASSED ] 3474 tests.", "parentUuid": "bfdf1a19_33b9ad86", "revId": "07f34d97711b91c3eb148d8c0e6955a0d5fb40d9", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" }, { "unresolved": false, "key": { "uuid": "38808fa2_c88d1009", "filename": "include/libyuv/row.h", "patchSetId": 5 }, "lineNbr": 826, "author": { "id": 1115898 }, "writtenOn": "2025-10-17T18:29:23Z", "side": 1, "message": "to clean this up in the future, we can requires a new compiler/intrinsics version and if not available, disable RVV entirely.", "revId": "07f34d97711b91c3eb148d8c0e6955a0d5fb40d9", "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba" } ], "submitRequirementResults": [ { "submitRequirement": { "name": "Admin-Approval", "description": { "value": "Changes to refs/meta/config must be approved by a git admin." }, "applicabilityExpression": { "value": { "expressionString": "branch:refs/meta/config" } }, "submittabilityExpression": { "expressionString": "(uploaderin:mdb/chrome-git-admins OR label:Code-Review\u003dMAX,group\u003dmdb/chrome-git-admins) AND label:Code-Review\u003dMAX,user\u003dnon_uploader AND -label:Code-Review\u003dMIN" }, "overrideExpression": { "value": { "expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN" } }, "allowOverrideInChildProjects": false }, "applicabilityExpressionResult": { "value": {"expression":{"expressionString":"branch:refs/meta/config"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}} }, "submittabilityExpressionResult": { "value": {"expression":{"expressionString":"(uploaderin:mdb/chrome-git-admins OR label:Code-Review=MAX,group=mdb/chrome-git-admins) AND label:Code-Review=MAX,user=non_uploader AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} }, "overrideExpressionResult": { "value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} }, "patchSetCommitId": "07f34d97711b91c3eb148d8c0e6955a0d5fb40d9", "legacy": { "value": false }, "forced": {}, "hidden": {} }, { "submitRequirement": { "name": "Code-Review", "description": { "value": "If the author is a libyuv committer, code review is required from one other committer. Otherwise, code review is required from two committers." }, "applicabilityExpression": { "value": { "expressionString": "-branch:refs/meta/config" } }, "submittabilityExpression": { "expressionString": "((uploaderin:cria/project-libyuv-committers AND label:Code-Review\u003dMAX,user\u003dnon_uploader) OR label:Code-Review\u003dMAX,count\u003e\u003d2) AND -label:Code-Review\u003dMIN" }, "overrideExpression": { "value": { "expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN" } }, "allowOverrideInChildProjects": true }, "applicabilityExpressionResult": { "value": {"expression":{"expressionString":"-branch:refs/meta/config"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}} }, "submittabilityExpressionResult": { "value": {"expression":{"expressionString":"((uploaderin:cria/project-libyuv-committers AND label:Code-Review=MAX,user=non_uploader) OR label:Code-Review=MAX,count>=2) AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX,user=non_uploader","label:Code-Review=MAX,count>=2"],"failingAtoms":["label:Code-Review=MIN","uploaderin:cria/project-libyuv-committers"],"atomExplanations":{"value":{"label:Code-Review=MIN":"","label:Code-Review=MAX,user=non_uploader":"","uploaderin:cria/project-libyuv-committers":"","label:Code-Review=MAX,count>=2":""}}} }, "overrideExpressionResult": { "value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Bot-Commit=+1","label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Bot-Commit=+1":"","label:Code-Review=MIN":""}}} }, "patchSetCommitId": "07f34d97711b91c3eb148d8c0e6955a0d5fb40d9", "legacy": { "value": false }, "forced": {}, "hidden": {} }, { "submitRequirement": { "name": "No-Unresolved-Comments", "description": { "value": "Changes that have unresolved comments are not submittable. Unless overridden with Unresolved-Comment-Reason: \u003creason\u003e line in change message." }, "applicabilityExpression": { "value": { "expressionString": "has:unresolved" } }, "submittabilityExpression": { "expressionString": "-has:unresolved" }, "overrideExpression": { "value": { "expressionString": "message:\"^.*Unresolved-Comment-Reason:.*\"" } }, "allowOverrideInChildProjects": false }, "applicabilityExpressionResult": { "value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"],"atomExplanations":{"value":{"has:unresolved":""}}} }, "submittabilityExpressionResult": { "value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} }, "overrideExpressionResult": { "value": {"expression":{"expressionString":"message:\"^.*Unresolved-Comment-Reason:.*\""},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} }, "patchSetCommitId": "07f34d97711b91c3eb148d8c0e6955a0d5fb40d9", "legacy": { "value": false }, "forced": {}, "hidden": {} }, { "submitRequirement": { "name": "Review-Enforcement", "description": { "value": "Two trusted contributors must approve the change. Uploading the change or voting positively on Code-Review count as approval. For Google employees, using a trusted device is required (go/gerrit-onboarding#review-enforcement). For non-Google employees, ReAuth is required (https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gerrit_reauth.md)." }, "applicabilityExpression": { "value": { "expressionString": "is:review-enforced_gerrit" } }, "submittabilityExpression": { "expressionString": "is:review-enforcement-satisfied_gerrit" }, "overrideExpression": {}, "allowOverrideInChildProjects": false }, "applicabilityExpressionResult": { "value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforced_gerrit":""}}} }, "submittabilityExpressionResult": { "value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforcement-satisfied_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforcement-satisfied_gerrit":"Required approval count satisfied"}}} }, "overrideExpressionResult": {}, "patchSetCommitId": "07f34d97711b91c3eb148d8c0e6955a0d5fb40d9", "legacy": { "value": false }, "forced": {}, "hidden": {} }, { "submitRequirement": { "name": "Verified", "description": { "value": "Submit requirement for the \u0027Verified\u0027 label" }, "applicabilityExpression": { "value": { "expressionString": "is:false" } }, "submittabilityExpression": { "expressionString": "is:true" }, "overrideExpression": {}, "allowOverrideInChildProjects": true }, "applicabilityExpressionResult": { "value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"],"atomExplanations":{"value":{"is:false":""}}} }, "submittabilityExpressionResult": { "value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}} }, "overrideExpressionResult": {}, "patchSetCommitId": "07f34d97711b91c3eb148d8c0e6955a0d5fb40d9", "legacy": { "value": false }, "forced": {}, "hidden": {} } ] }