mirror of
https://chromium.googlesource.com/libyuv/libyuv
synced 2026-02-10 20:29:53 +08:00
faf5318701
Patch Set 4:
(1 comment)
Patch-set: 4
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_3388142\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1178490 \u003c1178490@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_3388142\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 3388142 \u003c3388142@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_3388142\u003e replied on the change"}
57 lines
2.2 KiB
Plaintext
57 lines
2.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "df7cbdae_b8bf9b26",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1115898
|
|
},
|
|
"writtenOn": "2025-12-12T01:34:19Z",
|
|
"side": 1,
|
|
"message": "I put questions in the bug.\nthe cat command just returns \u0027commit\u0027? seems like a catch-22 to supply the version number to query the version number?",
|
|
"revId": "38376d739d4ff66d6182761e7f0c1f139f5d101f",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b17caa81_bf7c8236",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1178490
|
|
},
|
|
"writtenOn": "2025-12-12T09:00:00Z",
|
|
"side": 1,
|
|
"message": "Jordan, I think the question here is if we need to keep the `Version` in this file in sync with https://source.chromium.org/chromium/chromium/src/+/main:third_party/libyuv/include/libyuv/version.h of if that is not required.\n\nThis is a libyuv way to express its code version but Chromium cares about the git commit in the DEPS file.\n\nhttps://source.chromium.org/chromium/chromium/src/+/main:third_party/libyuv/include/libyuv/version.h is more of a way for libyuv to say \"you need at least version XXX\" and it might not be increased with all the commits.",
|
|
"parentUuid": "df7cbdae_b8bf9b26",
|
|
"revId": "38376d739d4ff66d6182761e7f0c1f139f5d101f",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f231ea35_738eb649",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 3388142
|
|
},
|
|
"writtenOn": "2025-12-22T03:15:39Z",
|
|
"side": 1,
|
|
"message": "This is not currently required for first party dependencies like this. You can set the version for documentation/maintenance purposes or provide \u0027N/A\u0027.",
|
|
"parentUuid": "b17caa81_bf7c8236",
|
|
"revId": "38376d739d4ff66d6182761e7f0c1f139f5d101f",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
}
|
|
]
|
|
} |