libyuv/3bfe5a2a8404f30b50936da9e1701caaa0c560a0

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "8477c202_3fc526a2",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 9,
      "author": {
        "id": 1115898
      },
      "writtenOn": "2025-09-29T18:10:16Z",
      "side": 1,
      "message": "best to trust but verify.  Using a code snippet you can try gcc and clang versions in godbolt.  I also ran into bugs with __riscv_v_intrinsic not set correctly.\nMy personal ability to test is with an old clang compiler on emulator, and in future I expect android builds which will come with newer clang versions",
      "revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "5c21afff_b58c4d01",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 9,
      "author": {
        "id": 3711818
      },
      "writtenOn": "2025-09-30T01:53:45Z",
      "side": 1,
      "message": "Yes, using Godbolt to check the definition of __riscv_v_intrinsic is indeed quite convenient. By the way, my current testing method involves downloading different versions of LLVM (llvm16, llvm17, llvm19, llvm21) from https://github.com/riscv-collab/riscv-gnu-toolchain/tags to cover different intrinsic versions, building libyuv, and testing it on the spacemit k1 (with RVV 1.0) board.",
      "parentUuid": "8477c202_3fc526a2",
      "revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "48b42b80_9c8ebcf4",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 2
      },
      "lineNbr": 0,
      "author": {
        "id": 1115898
      },
      "writtenOn": "2025-09-29T18:10:16Z",
      "side": 1,
      "message": "thanks for the update",
      "revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "731fbff1_215d1d0e",
        "filename": "include/libyuv/scale_row.h",
        "patchSetId": 2
      },
      "lineNbr": 173,
      "author": {
        "id": 1115898
      },
      "writtenOn": "2025-09-29T18:10:16Z",
      "side": 1,
      "message": "nit For consistency this line would go after line 176 // The following...",
      "revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "fcc48684_b01e2e73",
        "filename": "include/libyuv/scale_row.h",
        "patchSetId": 2
      },
      "lineNbr": 173,
      "author": {
        "id": 3711818
      },
      "writtenOn": "2025-09-30T01:45:43Z",
      "side": 1,
      "message": "Addressed",
      "parentUuid": "731fbff1_215d1d0e",
      "revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "6ead2a40_453a200c",
        "filename": "include/libyuv/scale_row.h",
        "patchSetId": 2
      },
      "lineNbr": 173,
      "author": {
        "id": 1115898
      },
      "writtenOn": "2025-09-30T01:50:47Z",
      "side": 1,
      "message": "Acknowledged",
      "parentUuid": "fcc48684_b01e2e73",
      "revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    }
  ]
}