mirror of
https://chromium.googlesource.com/libyuv/libyuv
synced 2026-06-15 08:26:06 +08:00
36251da436
Change has been successfully rebased and submitted as ccd415101d748628b6809354e95f974e640c06a3
Patch-set: 3
Patch-set-description: Rebase
Subject: Fix int negation overflow in ConvertToARGB/I420
Status: merged
Commit: ccd415101d748628b6809354e95f974e640c06a3
Tag: autogenerated:gerrit:merged
Groups: 91ca74f2e84cc1c45d5ba5bcf755899af81d45e5
Label: Code-Review=+1, 8d1bfe7bef0a5056415cc59ca9bf55bfc824c20a Gerrit User 1002219 <1002219@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Commit-Queue=+2, 953cc16729ae9da2184de1e569abe4558a898671 Gerrit User 1001562 <1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: SUBM=+1, 61d6b763c8e530053b2f0ea665143fd6e7d88de5
Submission-id: 7904588
Submitted-with: OK
Submitted-with: Rule-Name: gerrit~DefaultSubmitRule
Submitted-with: MAY: SLSA-Policy-Verified
Submitted-with: MAY: Auto-Submit
Submitted-with: MAY: Code-Coverage
Submitted-with: MAY: Code-Review: Gerrit User 1002219 <1002219@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Submitted-with: MAY: Commit-Queue: Gerrit User 1001562 <1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Submitted-with: MAY: Feels
Submitted-with: MAY: Owners-Override
Submitted-with: MAY: Lint
Submitted-with: MAY: Bot-Commit
Submitted-with: OK
Submitted-with: Rule-Name: Code-Owners
Base: f722313c743663dcf48d6650d18a4b99165a8d72
Ours: 91ca74f2e84cc1c45d5ba5bcf755899af81d45e5
Theirs: f722313c743663dcf48d6650d18a4b99165a8d72
Merge-Strategy: simple-two-way-in-core
Contains-Conflicts: false
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"Change was submitted"}
279 lines
12 KiB
Plaintext
279 lines
12 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ab204c48_7178569c",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 11,
|
|
"author": {
|
|
"id": 1002219
|
|
},
|
|
"writtenOn": "2026-06-05T19:04:45Z",
|
|
"side": 1,
|
|
"message": "No `Bug:`?",
|
|
"revId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8743d517_44318757",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 11,
|
|
"author": {
|
|
"id": 1001562
|
|
},
|
|
"writtenOn": "2026-06-05T19:06:14Z",
|
|
"side": 1,
|
|
"message": "No. I am analyzing libyuv myself.",
|
|
"parentUuid": "ab204c48_7178569c",
|
|
"revId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "66950250_7c62af7d",
|
|
"filename": "source/convert_to_argb.cc",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 65,
|
|
"author": {
|
|
"id": 1001562
|
|
},
|
|
"writtenOn": "2026-06-05T18:45:57Z",
|
|
"side": 1,
|
|
"message": "Before we negate `src_height` and `crop_height`, we need to make sure they are not equal to `INT_MIN`. So I moved the validation of parameters to the beginning of the function.",
|
|
"revId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a56246da_72346154",
|
|
"filename": "source/convert_to_i420.cc",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 52,
|
|
"author": {
|
|
"id": 1001562
|
|
},
|
|
"writtenOn": "2026-06-05T18:45:57Z",
|
|
"side": 1,
|
|
"message": "Before we negate `src_height` and `crop_height`, we need to make sure they are not equal to `INT_MIN`.\n\nThe validation of parameters uses the local variables `abs_src_height` and `abs_crop_height`, so it needs to be split into two parts.",
|
|
"revId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
}
|
|
],
|
|
"submitRequirementResults": [
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Admin-Approval",
|
|
"description": {
|
|
"value": "Changes to refs/meta/config must be approved by a git admin."
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "branch:refs/meta/config"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "(uploaderin:mdb/chrome-git-admins OR label:Code-Review\u003dMAX,group\u003dmdb/chrome-git-admins) AND label:Code-Review\u003dMAX,user\u003dnon_uploader AND -label:Code-Review\u003dMIN"
|
|
},
|
|
"overrideExpression": {
|
|
"value": {
|
|
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
|
|
}
|
|
},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"branch:refs/meta/config"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"(uploaderin:mdb/chrome-git-admins OR label:Code-Review=MAX,group=mdb/chrome-git-admins) AND label:Code-Review=MAX,user=non_uploader AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
|
},
|
|
"overrideExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
|
},
|
|
"patchSetCommitId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Code-Review",
|
|
"description": {
|
|
"value": "If the author is a libyuv committer, code review is required from one other committer. Otherwise, code review is required from two committers."
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "-branch:refs/meta/config"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "((uploaderin:cria/project-libyuv-committers AND label:Code-Review\u003dMAX,user\u003dnon_uploader) OR label:Code-Review\u003dMAX,count\u003e\u003d2) AND -label:Code-Review\u003dMIN"
|
|
},
|
|
"overrideExpression": {
|
|
"value": {
|
|
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
|
|
}
|
|
},
|
|
"allowOverrideInChildProjects": true
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"-branch:refs/meta/config"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"((uploaderin:cria/project-libyuv-committers AND label:Code-Review=MAX,user=non_uploader) OR label:Code-Review=MAX,count>=2) AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX,user=non_uploader","uploaderin:cria/project-libyuv-committers"],"failingAtoms":["label:Code-Review=MIN","label:Code-Review=MAX,count>=2"],"atomExplanations":{"value":{"label:Code-Review=MIN":"","label:Code-Review=MAX,user=non_uploader":"","uploaderin:cria/project-libyuv-committers":"","label:Code-Review=MAX,count>=2":""}}}
|
|
},
|
|
"overrideExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Bot-Commit=+1","label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Bot-Commit=+1":"","label:Code-Review=MIN":""}}}
|
|
},
|
|
"patchSetCommitId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "No-Unresolved-Comments",
|
|
"description": {
|
|
"value": "Changes that have unresolved comments are not submittable. Unless overridden with Unresolved-Comment-Reason: \u003creason\u003e line in change message."
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "has:unresolved"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "-has:unresolved"
|
|
},
|
|
"overrideExpression": {
|
|
"value": {
|
|
"expressionString": "message:\"^.*Unresolved-Comment-Reason:.*\""
|
|
}
|
|
},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"],"atomExplanations":{"value":{"has:unresolved":""}}}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
|
},
|
|
"overrideExpressionResult": {
|
|
"value": {"expression":{"expressionString":"message:\"^.*Unresolved-Comment-Reason:.*\""},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
|
},
|
|
"patchSetCommitId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Review-Enforcement",
|
|
"description": {
|
|
"value": "Two trusted contributors must approve the change. Uploading the change or voting positively on Code-Review count as approval. For Google employees, using a trusted device is required (http://go/gerrit-onboarding#review-enforcement). For non-Google employees, ReAuth is required (https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gerrit_reauth.md)."
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "is:review-enforced_gerrit"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "is:review-enforcement-satisfied_gerrit"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforced_gerrit":""}}}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforcement-satisfied_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforcement-satisfied_gerrit":"Required approval count satisfied"}}}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "SLSA-Policy-Verified",
|
|
"description": {
|
|
"value": "Verify that binaries are authorized and free from tampering at the configured level."
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "is:bcid-exit-gate-applicable_gerrit"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "label:SLSA-Policy-Verified\u003dMAX\u0026user\u003ddevtools-gerritcodereview-exitgate"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": false
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:bcid-exit-gate-applicable_gerrit"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:bcid-exit-gate-applicable_gerrit"],"atomExplanations":{"value":{"is:bcid-exit-gate-applicable_gerrit":""}}}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"label:SLSA-Policy-Verified=MAX&user=devtools-gerritcodereview-exitgate"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
},
|
|
{
|
|
"submitRequirement": {
|
|
"name": "Verified",
|
|
"description": {
|
|
"value": "Submit requirement for the \u0027Verified\u0027 label"
|
|
},
|
|
"applicabilityExpression": {
|
|
"value": {
|
|
"expressionString": "is:false"
|
|
}
|
|
},
|
|
"submittabilityExpression": {
|
|
"expressionString": "is:true"
|
|
},
|
|
"overrideExpression": {},
|
|
"allowOverrideInChildProjects": true
|
|
},
|
|
"applicabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"],"atomExplanations":{"value":{"is:false":""}}}
|
|
},
|
|
"submittabilityExpressionResult": {
|
|
"value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
|
},
|
|
"overrideExpressionResult": {},
|
|
"patchSetCommitId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"legacy": {
|
|
"value": false
|
|
},
|
|
"forced": {},
|
|
"hidden": {}
|
|
}
|
|
]
|
|
} |