mirror of
https://chromium.googlesource.com/libyuv/libyuv
synced 2025-12-12 06:29:57 +08:00
64eeb65bd2
Patch Set 3: Code-Review+1
(1 comment)
Patch-set: 3
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Code-Review=+1, c0c5f5688f94582e93be02af06c37768834bcd11
Attention: {"person_ident":"Gerrit User 3711818 \u003c3711818@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
91 lines
2.7 KiB
Plaintext
91 lines
2.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8477c202_3fc526a2",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 1115898
|
|
},
|
|
"writtenOn": "2025-09-29T18:10:16Z",
|
|
"side": 1,
|
|
"message": "best to trust but verify. Using a code snippet you can try gcc and clang versions in godbolt. I also ran into bugs with __riscv_v_intrinsic not set correctly.\nMy personal ability to test is with an old clang compiler on emulator, and in future I expect android builds which will come with newer clang versions",
|
|
"revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "48b42b80_9c8ebcf4",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1115898
|
|
},
|
|
"writtenOn": "2025-09-29T18:10:16Z",
|
|
"side": 1,
|
|
"message": "thanks for the update",
|
|
"revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "731fbff1_215d1d0e",
|
|
"filename": "include/libyuv/scale_row.h",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 173,
|
|
"author": {
|
|
"id": 1115898
|
|
},
|
|
"writtenOn": "2025-09-29T18:10:16Z",
|
|
"side": 1,
|
|
"message": "nit For consistency this line would go after line 176 // The following...",
|
|
"revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fcc48684_b01e2e73",
|
|
"filename": "include/libyuv/scale_row.h",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 173,
|
|
"author": {
|
|
"id": 3711818
|
|
},
|
|
"writtenOn": "2025-09-30T01:45:43Z",
|
|
"side": 1,
|
|
"message": "Addressed",
|
|
"parentUuid": "731fbff1_215d1d0e",
|
|
"revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "6ead2a40_453a200c",
|
|
"filename": "include/libyuv/scale_row.h",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 173,
|
|
"author": {
|
|
"id": 1115898
|
|
},
|
|
"writtenOn": "2025-09-30T01:50:47Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "fcc48684_b01e2e73",
|
|
"revId": "3bfe5a2a8404f30b50936da9e1701caaa0c560a0",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
}
|
|
]
|
|
} |