libyuv/57748f441f90326314c24fe894b1a03924db8275
Gerrit User 1001562 8b555bd972 Update patch set 9
Patch Set 9:

(1 comment)

Patch-set: 9
2025-10-16 13:28:43 -07:00

110 lines
3.4 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "3d35f537_33fc37ff",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 1002030
},
"writtenOn": "2025-10-16T00:14:42Z",
"side": 1,
"message": "lgtm",
"revId": "57748f441f90326314c24fe894b1a03924db8275",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "052132b8_abef1ba2",
"filename": "README.chromium",
"patchSetId": 5
},
"lineNbr": 3,
"author": {
"id": 1001562
},
"writtenOn": "2025-10-16T01:52:46Z",
"side": 1,
"message": "Please modify the version in the version header file.",
"revId": "57748f441f90326314c24fe894b1a03924db8275",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "f6a98f82_a5f0ff4d",
"filename": "README.chromium",
"patchSetId": 5
},
"lineNbr": 3,
"author": {
"id": 1115898
},
"writtenOn": "2025-10-16T18:30:39Z",
"side": 1,
"message": "Done",
"parentUuid": "052132b8_abef1ba2",
"revId": "57748f441f90326314c24fe894b1a03924db8275",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "925a0594_608639db",
"filename": "README.chromium",
"patchSetId": 5
},
"lineNbr": 3,
"author": {
"id": 1001562
},
"writtenOn": "2025-10-16T20:15:32Z",
"side": 1,
"message": "This is not done. Please modify the version in include/libyuv/version.h:\n\n```\ndiff --git a/include/libyuv/version.h b/include/libyuv/version.h\nindex 52f5a7cd..7c39017f 100644\n--- a/include/libyuv/version.h\n+++ b/include/libyuv/version.h\n@@ -11,6 +11,6 @@\n #ifndef INCLUDE_LIBYUV_VERSION_H_\n #define INCLUDE_LIBYUV_VERSION_H_\n \n-#define LIBYUV_VERSION 1920\n+#define LIBYUV_VERSION 1921\n \n #endif // INCLUDE_LIBYUV_VERSION_H_\n```",
"parentUuid": "f6a98f82_a5f0ff4d",
"revId": "57748f441f90326314c24fe894b1a03924db8275",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "8d7e88fc_35d32979",
"filename": "README.chromium",
"patchSetId": 5
},
"lineNbr": 3,
"author": {
"id": 1115898
},
"writtenOn": "2025-10-16T20:18:54Z",
"side": 1,
"message": "Acknowledged. The internal version is still up for review, so we can do some followup there",
"parentUuid": "925a0594_608639db",
"revId": "57748f441f90326314c24fe894b1a03924db8275",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "a94d35b5_8b840878",
"filename": "README.chromium",
"patchSetId": 5
},
"lineNbr": 3,
"author": {
"id": 1001562
},
"writtenOn": "2025-10-16T20:28:43Z",
"side": 1,
"message": "I converted this patch to a CL:\nhttps://chromium-review.googlesource.com/c/libyuv/libyuv/+/7050411",
"parentUuid": "8d7e88fc_35d32979",
"revId": "57748f441f90326314c24fe894b1a03924db8275",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}