mirror of
https://chromium.googlesource.com/libyuv/libyuv
synced 2025-12-08 01:36:47 +08:00
8faf11d6a8
Patch Set 2:
(1 comment)
Patch-set: 2
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
38 lines
1.2 KiB
Plaintext
38 lines
1.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f9625f5d_b220ec9e",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1115898
|
|
},
|
|
"writtenOn": "2025-10-27T20:45:51Z",
|
|
"side": 1,
|
|
"message": "f32mm detect for arm. tested on android/chrome emulator",
|
|
"revId": "f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b690f4b0_5b9f9cf5",
|
|
"filename": "include/libyuv/cpu_id.h",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 33,
|
|
"author": {
|
|
"id": 1001562
|
|
},
|
|
"writtenOn": "2025-10-27T21:12:51Z",
|
|
"side": 1,
|
|
"message": "I found that include/libyuv/cpu_id.h is a public header. For backward compatibility we should not change the values of the constants `kCpuHasSME` and `kCpuHasSME2`.\n\nAre `kCpuHasSME` and `kCpuHasSME2` part of libyuv\u0027s public API? Or are they actually internal constants and just exposed in a public header unintentionally?",
|
|
"revId": "f39d0b21a51dfcc89e169b0e96dcf7a8c80fffc7",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
}
|
|
]
|
|
} |