libyuv/b9d6a465653104af76ed18338c155c627cce148b
Gerrit User 1544499 1d2f4d86c9 Update patch set 1
Patch Set 1:

(1 comment)

Patch-set: 1
2024-07-19 18:50:49 +00:00

91 lines
2.9 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "ff3e153b_c4ace606",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1544499
},
"writtenOn": "2024-07-19T18:30:32Z",
"side": 1,
"message": "Sending the review to @prashanthsw@google.com as they updated the reclient version last",
"revId": "b9d6a465653104af76ed18338c155c627cce148b",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "d3b81bd0_8e45196e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1174609
},
"writtenOn": "2024-07-19T18:32:06Z",
"side": 1,
"message": "Nothing looks obviously incorrect to me here, but heads up that I don\u0027t have vote permissions and Frank should be the one to approve, added him here.",
"revId": "b9d6a465653104af76ed18338c155c627cce148b",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "9fb48e90_d1acde91",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1544499
},
"writtenOn": "2024-07-19T18:44:46Z",
"side": 1,
"message": "The relevant recipe change is https://chromium-review.googlesource.com/c/chromium/tools/build/+/5726001\nI cannot test these changes together via led because I do not have permissions to run builds on libyuv/try",
"revId": "b9d6a465653104af76ed18338c155c627cce148b",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "9899a101_b2e3ab8b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1544499
},
"writtenOn": "2024-07-19T18:49:34Z",
"side": 1,
"message": "After the recipe change goes in could someone who has permissions could run this change on a try builder? I will wait to submit until there is a successful try run",
"parentUuid": "9fb48e90_d1acde91",
"revId": "b9d6a465653104af76ed18338c155c627cce148b",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "aadb435a_ddf10a50",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1544499
},
"writtenOn": "2024-07-19T18:50:49Z",
"side": 1,
"message": "nvm I can run try builds from the cl presubmits it seems, ok I will just wait for the recipe change to go in then.",
"parentUuid": "9899a101_b2e3ab8b",
"revId": "b9d6a465653104af76ed18338c155c627cce148b",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}