mirror of
https://chromium.googlesource.com/libyuv/libyuv
synced 2026-02-15 22:59:53 +08:00
b16233e3d4
Patch Set 3: Code-Review+1 Commit-Queue+2
(2 comments)
Patch-set: 3
Reviewer: Gerrit User 1526622 <1526622@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Code-Review=+1, 3a305fd64ac477ba1dbc9e0eb61a73f870ef3d21
Label: Commit-Queue=+2, 09228e841d0a07a4b8a8f49af8b3467d76f8821a
Attention: {"person_ident":"Gerrit User 1526622 \u003c1526622@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 4524974 \u003c4524974@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
91 lines
3.1 KiB
Plaintext
91 lines
3.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a6479055_30eb93a2",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 4524974
|
|
},
|
|
"writtenOn": "2025-12-09T12:05:23Z",
|
|
"side": 1,
|
|
"message": "This was started by an FTBFS bug on Ubuntu: https://bugs.launchpad.net/ubuntu/+source/libyuv/+bug/2134454\n\nFull Ubuntu build with patch applied was done in a Launchpad ppa: https://launchpad.net/~vhaudiquet/+archive/ubuntu/libyuv-lp2134454/+build/31574520",
|
|
"revId": "a47e0c8cf4f28716867fb070146632e6add22c2b",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ee55f6f9_b05a01c9",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1115898
|
|
},
|
|
"writtenOn": "2025-12-10T03:09:03Z",
|
|
"side": 1,
|
|
"message": "thanks for the change... should be fine.\nif you\u0027re feeling ambitious the arm sme code is in a similar state. :-)",
|
|
"revId": "a47e0c8cf4f28716867fb070146632e6add22c2b",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "76088842_309ed602",
|
|
"filename": "source/row_rvv.cc",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 21,
|
|
"author": {
|
|
"id": 1115898
|
|
},
|
|
"writtenOn": "2025-12-10T03:09:03Z",
|
|
"side": 1,
|
|
"message": "this is fine but the very last line of these files has a comment defined(__clang__)\ncould you remove those as well?\n\nas far as I know, theres no visual c or other compilers that support rvv, but this will enable all of them.",
|
|
"revId": "a47e0c8cf4f28716867fb070146632e6add22c2b",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "795f8f00_eda31d03",
|
|
"filename": "source/row_rvv.cc",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 21,
|
|
"author": {
|
|
"id": 4524974
|
|
},
|
|
"writtenOn": "2025-12-10T08:33:58Z",
|
|
"side": 1,
|
|
"message": "Done! I removed those comments. Thanks for pointing it out, don\u0027t know how I missed them.\n\nI don\u0027t think Visual C even supports the RISC-V ISA? Would you prefer it with CLANG *and* GCC guards? I think this should be fine as is, right?",
|
|
"parentUuid": "76088842_309ed602",
|
|
"revId": "a47e0c8cf4f28716867fb070146632e6add22c2b",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "c2a57d99_4f2391e9",
|
|
"filename": "source/row_rvv.cc",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 21,
|
|
"author": {
|
|
"id": 1115898
|
|
},
|
|
"writtenOn": "2025-12-10T18:37:13Z",
|
|
"side": 1,
|
|
"message": "Na... lets let all compilers attempt to do RVV.",
|
|
"parentUuid": "795f8f00_eda31d03",
|
|
"revId": "a47e0c8cf4f28716867fb070146632e6add22c2b",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
}
|
|
]
|
|
} |