mirror of
https://chromium.googlesource.com/libyuv/libyuv
synced 2025-12-14 23:49:57 +08:00
9cc81afb47
Patch Set 2: Code-Review+1
(1 comment)
Patch-set: 2
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Code-Review=+1, 4163703ccb2ea735fe96186ca667409fb46405e0
Attention: {"person_ident":"Gerrit User 3775295 \u003c3775295@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
38 lines
1.4 KiB
Plaintext
38 lines
1.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8ba61731_7ca9084d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 3775295
|
|
},
|
|
"writtenOn": "2024-12-04T13:03:13Z",
|
|
"side": 1,
|
|
"message": "Hi, I am a developer of Tencent. Our project requires scaling for the NV24 format, but the function is currently missing in scale.h. This commit adds the necessary implementation to support NV24 scaling.",
|
|
"revId": "dcbf20c24c28b9b662fd44f2e5a5165e3d4e0789",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8c849ee2_236a62c4",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1115898
|
|
},
|
|
"writtenOn": "2024-12-12T09:48:20Z",
|
|
"side": 1,
|
|
"message": "Thanks for the contribution! Looks good. Would be nice to have a unit test, but really the planar functions need more complete tests.\nIn the future there is P010 that is equivalent to NV12 but 10 bit and P410 is like NV24 with 4:4:4 subsampling.\nAlso NV42 is the same as NV24 but VU vs UV, which doesnt matter, but you might provide a macro in the header",
|
|
"revId": "dcbf20c24c28b9b662fd44f2e5a5165e3d4e0789",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
}
|
|
]
|
|
} |