mirror of
https://chromium.googlesource.com/libyuv/libyuv
synced 2026-06-15 08:26:06 +08:00
e170676df3
Patch Set 2:
(2 comments)
Patch-set: 2
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Reviewer: Gerrit User 1002219 <1002219@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Attention: {"person_ident":"Gerrit User 1002219 \u003c1002219@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
38 lines
1.3 KiB
Plaintext
38 lines
1.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "66950250_7c62af7d",
|
|
"filename": "source/convert_to_argb.cc",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 65,
|
|
"author": {
|
|
"id": 1001562
|
|
},
|
|
"writtenOn": "2026-06-05T18:45:57Z",
|
|
"side": 1,
|
|
"message": "Before we negate `src_height` and `crop_height`, we need to make sure they are not equal to `INT_MIN`. So I moved the validation of parameters to the beginning of the function.",
|
|
"revId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a56246da_72346154",
|
|
"filename": "source/convert_to_i420.cc",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 52,
|
|
"author": {
|
|
"id": 1001562
|
|
},
|
|
"writtenOn": "2026-06-05T18:45:57Z",
|
|
"side": 1,
|
|
"message": "Before we negate `src_height` and `crop_height`, we need to make sure they are not equal to `INT_MIN`.\n\nThe validation of parameters uses the local variables `abs_src_height` and `abs_crop_height`, so it needs to be split into two parts.",
|
|
"revId": "91ca74f2e84cc1c45d5ba5bcf755899af81d45e5",
|
|
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
|
}
|
|
]
|
|
} |