libyuv/26cc49c78385cd6125565836e3f5b6d0b007bb29

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "83c39674_03397b40",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 1178490
      },
      "writtenOn": "2024-12-13T15:18:13Z",
      "side": 1,
      "message": "The ASan bot shows some issues in the test code: https://logs.chromium.org/logs/libyuv/buildbucket/cr-buildbucket/8728655592990558785/+/u/libyuv_unittest/stdout.\n\nTSan and MSan seems broken and we need to take a look on libyuv side.\n\nCan you take a look at the ASan issue?",
      "revId": "26cc49c78385cd6125565836e3f5b6d0b007bb29",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "2ec6d390_965f0822",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 1001562
      },
      "writtenOn": "2024-12-13T16:04:59Z",
      "side": 1,
      "message": "The asan errors are reported on Linux x86_64. Since these two CLs modify arm64 code only, they cannot possibly introduce the asan errors on Linux x86_64. So we can justify submitting these two CLs first, while we investigate the asan errors on Linux x86_64.\n\nI am going to build libyuv_unittest with asan on Linux x86_64 now and see if I can reproduce the asan errors.",
      "parentUuid": "83c39674_03397b40",
      "revId": "26cc49c78385cd6125565836e3f5b6d0b007bb29",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "5a759c3c_4f240cf2",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 1571352
      },
      "writtenOn": "2024-12-13T16:08:25Z",
      "side": 1,
      "message": "It seems like the dst_c and dst_opt buffers in TestHalfFloatPlane are simply never freed, should be an easy fix. I will put up a patchset to fix.",
      "parentUuid": "2ec6d390_965f0822",
      "revId": "26cc49c78385cd6125565836e3f5b6d0b007bb29",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "5150c135_36f3bb44",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 1178490
      },
      "writtenOn": "2024-12-13T16:16:43Z",
      "side": 1,
      "message": "Thanks!",
      "parentUuid": "5a759c3c_4f240cf2",
      "revId": "26cc49c78385cd6125565836e3f5b6d0b007bb29",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "89e42b0b_e0c5dbf2",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 1001562
      },
      "writtenOn": "2024-12-13T16:41:26Z",
      "side": 1,
      "message": "George: Thanks for taking a look. I am sorry I missed your comment. I was heads down investigating the memory leaks and did not check email until I was done.",
      "parentUuid": "5150c135_36f3bb44",
      "revId": "26cc49c78385cd6125565836e3f5b6d0b007bb29",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "af82e681_731bbb95",
        "filename": "include/libyuv/row_sve.h",
        "patchSetId": 1
      },
      "lineNbr": 27,
      "author": {
        "id": 1001562
      },
      "writtenOn": "2024-12-13T14:57:37Z",
      "side": 1,
      "message": "Nit: The comment after `#else` can be omitted after a short `#if` block.",
      "revId": "26cc49c78385cd6125565836e3f5b6d0b007bb29",
      "serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
    }
  ]
}