Remove some test cases that are not really meaningful

Remove the "srv" variant of "DTLS proxy: server: get invalid AD record then
accept renego", where the server initiates the renegotiation process by
sending a HelloRequest. The HelloRequest message is not relevant to this
test. The first message of the actual renegotiation is the ClientHello
message from the client, and the interesting part of the test happens when
the client receives the server's response.

Remove "DTLS proxy: server: get invalid AD record then accept early
renego (cli)" and the corresponding "reject" control. This test case doesn't
really do what it is advertised to do, and in particular does not lead to a
call to `ssl_consume_current_message()` in the server. What happens is that
the client sends a ClientHello message to start the renegotiation, then it
blocks until the server has replied. So there is nothing to delay that
ClientHello after:(unlike what happens in the corresponding client-side
test, where the first flight of the renegotiation protocol contains multiple
messages, so we can delay the first of these messages after the second one).
What happens in practice is that the client times out, then resends its
ClientHello, and the proxy sends the delayed ClientHello immediately after
the resent one, which does not cause any interesting behavior in the server.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

tests/ssl-opt.sh

@@ -11835,7 +11835,7 @@ run_test    "DTLS proxy: client: get invalid AD record then reject renego" \
             -C "Consume: waiting for more handshake fragments"
 
 requires_config_enabled MBEDTLS_SSL_RENEGOTIATION
-run_test    "DTLS proxy: server: get invalid AD record then reject renego (cli)" \
+run_test    "DTLS proxy: server: get invalid AD record then reject renego" \
             -p "$P_PXY bad_ad_cli_once=1" \
             "$P_SRV dtls=1 dgram_packing=0 hs_timeout=500-10000 \
              renegotiation=0 exchanges=4 \
@@ -11872,25 +11872,7 @@ run_test    "DTLS proxy: client: get invalid AD record then accept renego" \
             -C "Consume: waiting for more handshake fragments"
 
 requires_config_enabled MBEDTLS_SSL_RENEGOTIATION
-run_test    "DTLS proxy: server: get invalid AD record then accept renego (srv)" \
-            -p "$P_PXY bad_ad_cli_once=1" \
-            "$P_SRV dtls=1 dgram_packing=0 hs_timeout=500-10000 \
-             renegotiate=1 renegotiation=1 exchanges=4 \
-             badmac_limit=99 debug_level=3" \
-            "$P_CLI dtls=1 dgram_packing=0 hs_timeout=500-10000 \
-             renegotiation=1 exchanges=4 debug_level=3" \
-            0 \
-            -s "discarding invalid record (mac)" \
-            -s "=> renegotiate" \
-            -c "=> renegotiate" \
-            -s "Extra-header:" \
-            -c "HTTP/1.0 200 OK" \
-            -S "too many records with bad MAC" \
-            -S "Verification of the message MAC failed" \
-            -S "Consume: waiting for more handshake fragments"
-
-requires_config_enabled MBEDTLS_SSL_RENEGOTIATION
-run_test    "DTLS proxy: server: get invalid AD record then accept renego (cli)" \
+run_test    "DTLS proxy: server: get invalid AD record then accept renego" \
             -p "$P_PXY bad_ad_cli_once=1" \
             "$P_SRV dtls=1 dgram_packing=0 hs_timeout=500-10000 \
              renegotiation=1 exchanges=4 \
@@ -11965,43 +11947,6 @@ run_test    "DTLS proxy: client: get invalid AD record then accept early renego"
             -C "Verification of the message MAC failed" \
             -C "Consume: waiting for more handshake fragments"
 
-requires_config_enabled MBEDTLS_SSL_RENEGOTIATION
-run_test    "DTLS proxy: server: get invalid AD record then reject early renego (cli)" \
-            -p "$P_PXY bad_ad_cli_once=1 delay_encrypted_hs_cli=2" \
-            "$P_SRV dtls=1 dgram_packing=0 hs_timeout=500-10000 \
-             renegotiation=0 exchanges=4 \
-             badmac_limit=99 debug_level=3" \
-            "$P_CLI dtls=1 dgram_packing=0 hs_timeout=500-10000 \
-             renegotiation=1 renegotiate=2 exchanges=4 debug_level=3" \
-            1 \
-            -s "discarding invalid record (mac)" \
-            -c "=> renegotiate" \
-            -S "=> renegotiate" \
-            -s "refusing renegotiation" \
-            -s "Extra-header:" \
-            -c "HTTP/1.0 200 OK" \
-            -S "too many records with bad MAC" \
-            -S "Verification of the message MAC failed" \
-            -S "Consume: waiting for more handshake fragments"
-
-requires_config_enabled MBEDTLS_SSL_RENEGOTIATION
-run_test    "DTLS proxy: server: get invalid AD record then accept early renego (cli)" \
-            -p "$P_PXY bad_ad_cli_once=1 delay_encrypted_hs_cli=2" \
-            "$P_SRV dtls=1 dgram_packing=0 hs_timeout=500-10000 \
-             renegotiation=1 exchanges=4 \
-             badmac_limit=99 debug_level=3" \
-            "$P_CLI dtls=1 dgram_packing=0 hs_timeout=500-10000 \
-             renegotiation=1 renegotiate=2 exchanges=4 debug_level=3" \
-            0 \
-            -s "discarding invalid record (mac)" \
-            -c "=> renegotiate" \
-            -s "=> renegotiate" \
-            -s "Extra-header:" \
-            -c "HTTP/1.0 200 OK" \
-            -S "too many records with bad MAC" \
-            -S "Verification of the message MAC failed" \
-            -S "Consume: waiting for more handshake fragments"
-
 requires_config_enabled MBEDTLS_SSL_PROTO_TLS1_2
 run_test    "DTLS proxy: delay ChangeCipherSpec" \
             -p "$P_PXY delay_ccs=1" \