coffee/mio
1
0
Fork 0
mirror of https://github.com/vimpunk/mio.git synced 2025-12-06 08:46:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update basic_mmap destructor sync behavior

Browse Source
This commit is contained in:
mandreyel 2018-10-22 14:57:47 +02:00
parent 98d0d875b5
commit 865d7f35ce
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/mio/detail/mmap.ipp
View File

@ -188,6 +188,7 @@ inline mmap_context memory_map(const file_handle_type file_handle, const int64_t
template<access_mode AccessMode, typename ByteT>
basic_mmap<AccessMode, ByteT>::~basic_mmap()
{
conditional_sync();
unmap();
}
@ -278,8 +279,8 @@ void basic_mmap<AccessMode, ByteT>::map(const String& path, const size_type offs
}
template<access_mode AccessMode, typename ByteT>
void basic_mmap<AccessMode, ByteT>::map(const handle_type handle, const size_type offset,
const size_type length, std::error_code& error)
void basic_mmap<AccessMode, ByteT>::map(const handle_type handle,
const size_type offset, const size_type length, std::error_code& error)
{
error.clear();
if(handle == invalid_handle)

11
include/mio/mmap.hpp
View File

@ -325,6 +325,17 @@ private:
{
return !data() ? nullptr : data() - offset();
}
/**
* The destructor syncs changes to disk if `AccessMode` is `write`, but not
* if it's `read`, but since the destructor cannot be templated, we need to
* do SFINAE in a dedicated function, where one syncs and the other is a noop.
*/
template<access_mode A = AccessMode,
typename = typename std::enable_if<A == access_mode::write>::type>
void conditional_sync() { sync(); }
template<access_mode A = AccessMode>
typename std::enable_if<A == access_mode::read, void>::type conditional_sync() {}
};
template<access_mode AccessMode, typename ByteT>