coffee/mio
1
0
Fork 0
mirror of https://github.com/vimpunk/mio.git synced 2025-12-06 08:46:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix file length calculation bug and half-missing comment

Browse Source
This commit is contained in:
mandreyel 2018-11-27 12:02:46 +01:00
parent e2fdbf6c35
commit c7c7163a82
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/mio/detail/mmap.ipp
View File

@ -331,7 +331,7 @@ void basic_mmap<AccessMode, ByteT>::map(const handle_type handle,
} }
const auto ctx = detail::memory_map(handle, offset, const auto ctx = detail::memory_map(handle, offset,
length == map_entire_file ? file_size : length, length == map_entire_file ? (file_size - offset) : length,
AccessMode, error); AccessMode, error);
if(!error) if(!error)
{ {

10
include/mio/mmap.hpp
View File

@ -57,7 +57,7 @@ template<access_mode AccessMode, typename ByteT>
struct basic_mmap struct basic_mmap
{ {
using value_type = ByteT; using value_type = ByteT;
using size_type = int64_t; using size_type = size_t;
using reference = value_type&; using reference = value_type&;
using const_reference = const value_type&; using const_reference = const value_type&;
using pointer = value_type*; using pointer = value_type*;
@ -90,9 +90,11 @@ private:
handle_type file_mapping_handle_ = INVALID_HANDLE_VALUE; handle_type file_mapping_handle_ = INVALID_HANDLE_VALUE;
#endif #endif
// some complexity in that we must not close the file handle if user provided it, // Letting user map a file using both an existing file handle and a path
// but we must close it if we obtained it using the provided path. For this reason, // introcudes some complexity in that we must not close the file handle if
// this flag is used to determine when to close file_handle_. // user provided it, but we must close it if we obtained it using the
// provided path. For this reason, this flag is used to determine when to
// close file_handle_.
bool is_handle_internal_; bool is_handle_internal_;
public: public: