Move access_mode to page.hpp

include/mio/detail/basic_mmap.hpp

@@ -21,6 +21,8 @@
 #ifndef MIO_BASIC_MMAP_HEADER
 #define MIO_BASIC_MMAP_HEADER
 
+#include "../page.hpp"
+
 #include <iterator>
 #include <string>
 #include <system_error>
@@ -39,12 +41,6 @@ namespace detail {
 
 enum { map_entire_file = 0 };
 
-enum class access_mode
-{
-    read,
-    write
-};
-
 #ifdef _WIN32
     using file_handle_type = HANDLE;
 #else

include/mio/mmap.hpp

@@ -22,15 +22,12 @@
 #define MIO_MMAP_HEADER
 
 #include "detail/basic_mmap.hpp"
+#include "page.hpp"
 
 #include <system_error>
 
 namespace mio {
 
-// This is used by basic_mmap to determine whether to create a read-only or a read-write
-// memory mapping. The two possible values are `read` and `write`.
-using detail::access_mode;
-
 // This value may be provided as the `length` parameter to the constructor or
 // `map`, in which case a memory mapping of the entire file is created.
 using detail::map_entire_file;

include/mio/page.hpp

@@ -32,6 +32,16 @@
 
 namespace mio {
 
+/**
+ * This is used by `basic_mmap` to determine whether to create a read-only or
+ * a read-write memory mapping.
+ */
+enum class access_mode
+{
+    read,
+    write
+};
+
 /**
  * Determines the operating system's page allocation granularity.
  *

include/mio/shared_mmap.hpp

@@ -78,12 +78,12 @@ public:
     }
 
     /** Initializes this object with an already established shared mmap. */
-    basic_shared_mmap(std::shared_ptr<mmap_type> mmap) : pimpl_(mmap) {}
+    basic_shared_mmap(std::shared_ptr<mmap_type> mmap) : pimpl_(std::move(mmap)) {}
 
     /** Initializes this object with an already established shared mmap. */
     basic_shared_mmap& operator=(std::shared_ptr<mmap_type> mmap)
     {
-        pimpl_ = mmap;
+        pimpl_ = std::move(mmap);
         return *this;
     }