coffee/libyuv
1
0
Fork 0
mirror of https://chromium.googlesource.com/libyuv/libyuv synced 2026-07-30 16:26:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update patch set 3

Browse Source 
Patch Set 3:

(5 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
This commit is contained in:
Gerrit User 1001562 2026-07-27 14:35:13 -07:00 committed by Gerrit Code Review
parent 9ea35c3221
commit 298e83b61a
2 changed files with 92 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
407f21fe2985bc4a7a0c746e4e411bfe3a16af46
View File

@ -34,6 +34,24 @@
"revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "49622805_8d3cd182",
"filename": "include/libyuv/scale_row.h",
"patchSetId": 2
},
"lineNbr": 200,
"author": {
"id": 1001562
},
"writtenOn": "2026-07-27T21:35:13Z",
"side": 1,
"message": "Done. I moved the overflow checks to the callers. Note that the overflow checks are not obvious when they are performned by the callers because the operation that could overflow isn\u0027t there.",
"parentUuid": "67be1114_3bb92ffb",
"revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
@ -69,6 +87,24 @@
"revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "68892df7_6a53e8b6",
"filename": "source/convert.cc",
"patchSetId": 2
},
"lineNbr": 297,
"author": {
"id": 1001562
},
"writtenOn": "2026-07-27T21:35:13Z",
"side": 1,
"message": "Thank you for the analysis. In `FixedDiv(height, uv_height)`, we have `num\u003dheight` and `div\u003duv_height`. So the quotient is \u003c\u003d 2 and won\u0027t overflow.",
"parentUuid": "493e92b1_e844beab",
"revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
@ -86,6 +122,24 @@
"revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "5090ebc4_bafbc4d5",
"filename": "source/convert.cc",
"patchSetId": 2
},
"lineNbr": 302,
"author": {
"id": 1001562
},
"writtenOn": "2026-07-27T21:35:13Z",
"side": 1,
"message": "Done. Changed the return type of `ScalePlaneVertical_16To8()` back to `void`.",
"parentUuid": "b87b7250_b3590de7",
"revId": "407f21fe2985bc4a7a0c746e4e411bfe3a16af46",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {

38
4a636caa076c10b7aec2fa749e7589394d44d74f Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "87917200_e9264452",
"filename": "source/scale.cc",
"patchSetId": 3
},
"lineNbr": 2100,
"author": {
"id": 1001562
},
"writtenOn": "2026-07-27T21:35:13Z",
"side": 1,
"message": "I corrected the parameter name in the comment. The parameter is named `wpp`, not `bpp`.",
"revId": "4a636caa076c10b7aec2fa749e7589394d44d74f",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "458bb52f_b320e91e",
"filename": "source/scale_argb.cc",
"patchSetId": 3
},
"lineNbr": 751,
"author": {
"id": 1001562
},
"writtenOn": "2026-07-27T21:35:13Z",
"side": 1,
"message": "The `ScalePlaneVertical()` call performs the multiplication `clip_width * 4` using the `int` type. This detects overflow in that multiplication.\n\nNote that the reason for the `clip_width \u003e INT_MAX / 4` check is not obvious when it is performed by the caller.",
"revId": "4a636caa076c10b7aec2fa749e7589394d44d74f",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}