coffee/libyuv
1
0
Fork 0
mirror of https://chromium.googlesource.com/libyuv/libyuv synced 2025-12-12 06:29:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update patch set 2

Browse Source 
Patch Set 2:

(2 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1571352\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1526622 \u003c1526622@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1571352\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1571352\u003e replied on the change"}
This commit is contained in:
Gerrit User 1571352 2024-12-12 03:00:04 -08:00 committed by Gerrit Code Review
parent de90b06033
commit e0e1fca1be
2 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
b119232c3dcd49bc54f76c732ec21d0ed60617bc
View File

@ -33,6 +33,24 @@
"message": "theres pros and cons to this approach, but the end result is roughly 4x less code, so thats a win.\nIts a little hard to see how the macros piece together into a row function because they are far away from the wrapper. If each macro is basically only used once, it may be easier to understand it if its just above the function?",
"revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "428cf28e_d73d5563",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1571352
},
"writtenOn": "2024-12-12T11:00:04Z",
"side": 1,
"message": "I\u0027ve moved a couple of macros above their usage, however most of the READ and conversion macros are used in multiple places so I think it makes more sense to keep them together since the register passing conventions between macros is pretty similar.",
"parentUuid": "b26ed1c6_e79a978d",
"revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}

21
b20ec337d1b81b7d504ee2e2e4fccd21030c2bb6 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "0225e5cf_82722beb",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1571352
},
"writtenOn": "2024-12-12T11:00:04Z",
"side": 1,
"message": "(rebased)",
"revId": "b20ec337d1b81b7d504ee2e2e4fccd21030c2bb6",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}