coffee/libyuv
1
0
Fork 0
mirror of https://chromium.googlesource.com/libyuv/libyuv synced 2026-07-30 16:26:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update patch set 2

Browse Source 
Patch Set 2: Code-Review+1

(1 comment)

Patch-set: 2
Label: Code-Review=+1, 117c04a3befb0dfcaa8cb24864bea7e290b4a1be
Label: Commit-Queue=0, 81501571ddf4c2528bf4b996a95795535d938edb
This commit is contained in:
Gerrit User 1115898 2026-07-21 10:49:33 -07:00 committed by Gerrit Code Review
parent b426d48306
commit fa76ac2a4a
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
8e3bb9d16f1d9d3e35b905f47fd775371f7b55a5
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "e955db88_e18f2de9",
"filename": "source/row_common.cc",
"patchSetId": 1
},
"lineNbr": 3316,
"author": {
"id": 1115898
},
"writtenOn": "2026-07-21T17:49:33Z",
"side": 1,
"message": "If this code is taken as verbatim, this adds an add or lea.\n\nThe original code would use \u0027indexed+offset\u0027 addressing which is best for Intel.\n\nAn alternative would be use 2 pointers. Which can do the ptr +\u003d 4 \u0027for free\u0027 on arm.\nAlthough post increment doesnt take an instruction, it does take a microop, so on high end arm this isnt faster.\n\nIsn\u0027t the original index by an int (stride) a clean way to index pointers?",
"revId": "8e3bb9d16f1d9d3e35b905f47fd775371f7b55a5",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {