Bot-Commit+1 currently overrides Code-Review submit requirement even if a CR-1 vote exists.
Bug: 1314177
Change-Id: Iba4b5c0202ad7ba0f69498d482d24a5f18e3daf7
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/3966660
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Submittability rules are now enforced by new submit requirements that
are defined in the same project.config. Removing the legacy label
functions.
Change-Id: I91fdee0b6beb965ceebd6f4137263fd7f24299a5
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/3478561
Reviewed-by: Gavin Mak <gavinmak@google.com>
Rules for creating new submit requirements are as follows:
* We don't create submit requirements for labels that are not blocking.
* For labels that do not define any values, we assume they are
overriding a label definition from the parent project (i.e. to ignore
this label in the child project), hence we create a non-applicable
submit requirement for them.
* For other blocking labels, we create a corresponding submit
requirement for them.
Note that for the 'Code-Review' requirement we also set the overrideIf
condition to 'Bot-Commit=+1' since this requirement is currently
enforced from All-Projects rules.pl [1]. When this change is submitted,
the Code-Review SR in this change will be authoritative for the project
and needs to behave in the same way as was previously configured.
[1] https://chromium.googlesource.com/All-Projects/+/5ddd22e7537172878280dc2b47373251e842dda7/rules.pl#7
Change-Id: I5b8e7b6fb9b28c5266f94f97d5c81e273a72872c
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/3398373
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
For now, I replicated permissions already give to chrome-commit-bot
group. However, I deleted some permissions not used by CQ.
Bug: 1203284
Change-Id: I5ac3166694d5cb7305e8bbb6fe6dc710d71f1b62
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/2854574
Reviewed-by: Andy Perelson <ajp@chromium.org>
