Patch Set 4: Code-Review+1
(4 comments)
Patch-set: 4
Reviewer: Gerrit User 1001562 <1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Code-Review=+1, 7ba8167943cf9cdecdadfa46973204fb6e0df931
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Patch Set 4: -Commit-Queue
(Performed by <GERRIT_ACCOUNT_1347058> on behalf of <GERRIT_ACCOUNT_1115898>)
Patch-set: 4
Tag: autogenerated:cq:dry-run
Label: Commit-Queue=0, 1b779c8ba08bcde6326d1417103afb0f8e0da191
Real-user: Gerrit User 1347058 <1347058@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Patch Set 4:
(10 comments)
PS4: Undid the interim +/-32767 height cap from https://crrev.com/c/8524280 as requested, restored the dst_height == 1 && src_height >= 32768 checks in ScalePlane and ScalePlane_16 with updated comments, and updated unit tests in scale_plane_test.cc back to kSrcHeight = 32768.
Patch-set: 4
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"Someone else replied on a comment you posted"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"removed on reply"}
Uploaded patch set 4.
Undo 32767 height cap from crrev.com/c/8524280 and address review comments
Patch-set: 4
Patch-set-description: Undo 32767 height cap from crrev.com/c/8524280 and address review comments
Subject: Avoid signed int overflow in scale functions using uint32_t
Commit: 8dabf898eeee2e08d41666ee24533da35f4dcee7
Tag: autogenerated:gerrit:newPatchSet
Groups: 8dabf898eeee2e08d41666ee24533da35f4dcee7
Patch Set 3:
(7 comments)
Patch-set: 3
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Patch-set: 3
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"Someone else replied on a comment you posted"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"removed on reply"}
Patch Set 2:
(17 comments)
PS3: rebased onto main (https://crrev.com/c/8524280 now caps |src_height| at 32767 for ScalePlane/UVScale), addressed all comments, and trimmed the CL: scale_argb.cc keeps int64_t from main (bounds checks only), scale_common.cc only changes the ScaleSlope dst_width == 1 check, and the dead dst_height == 1 && src_height >= 32768 branches and the unneeded max_y clamps in ScalePlaneSimple/ScaleUVSimple are gone. Diff is now +237/-125 (was +341/-198). Verified with UBSan/MSan locally (SIMD and LIBYUV_DISABLE_ASM=1) and clean builds for x86-32, arm32, riscv64.
Patch-set: 2
Uploaded patch set 3.
Address review comments; rebase on main
Patch-set: 3
Patch-set-description: Address review comments; rebase on main
Subject: Avoid signed int overflow in scale functions using uint32_t
Commit: f69573745a6adb0119f173b6df8ccd6d75b47fb9
Tag: autogenerated:gerrit:newPatchSet
Groups: f69573745a6adb0119f173b6df8ccd6d75b47fb9
Uploaded patch set 2.
Avoid signed int overflow in scale functions using uint32_t
Patch-set: 2
Patch-set-description: Avoid signed int overflow in scale functions using uint32_t
Subject: Avoid signed int overflow in scale functions using uint32_t
Commit: 7fcaff2f76bed0446cc4350efeabf40305962007
Tag: autogenerated:gerrit:newPatchSet
Groups: 7fcaff2f76bed0446cc4350efeabf40305962007
Patch Set 1:
(1 comment)
Patch-set: 1
Reviewer: Gerrit User 3678755 <3678755@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 3678755 \u003c3678755@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
Patch Set 1:
(1 comment)
Patch-set: 1
Reviewer: Gerrit User 1001562 <1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
