Compare commits

...

6 Commits

Author SHA1 Message Date
Gerrit User 1001562
8b555bd972 Update patch set 9
Patch Set 9:

(1 comment)

Patch-set: 9
2025-10-16 13:28:43 -07:00
Gerrit User 1115898
1781af34b2 Update patch set 9
Patch Set 9:

(1 comment)

Patch-set: 9
Label: Commit-Queue=0, 5d9efbd2eb8aab63b2dfa35ce183a68129314e1f
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
2025-10-16 13:18:54 -07:00
Gerrit User 1001562
4d7eca4f6c Update patch set 9
Patch Set 9:

(1 comment)

Patch-set: 9
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1001562\u003e replied on the change"}
2025-10-16 13:15:32 -07:00
Gerrit User 1115898
ccc48fa62e Create patch set 9
Change has been successfully rebased and submitted as 2b4453d46faebcad72d744d763a4e3b1e97d338d

Patch-set: 9
Patch-set-description: Rebase
Subject: Deprecate MIPS and MSA support.
Status: merged
Commit: 2b4453d46faebcad72d744d763a4e3b1e97d338d
Tag: autogenerated:gerrit:merged
Groups: cf12588f4f797ff63d2feb6a366ced010790e8d1
Label: Code-Review=+1, e6e230ffa2800f75e0298ef804c8fee5d1b15454 Gerrit User 1526622 <1526622@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Commit-Queue=0, b5eff3011dcbef389100459650c70fb2e8182ddc
Label: SUBM=+1, f65c7af9c1fdbcd45e227351db26a67e0d9c2b72
Submission-id: 7045953
Submitted-with: OK
Submitted-with: Rule-Name: gerrit~DefaultSubmitRule
Submitted-with: MAY: Auto-Submit
Submitted-with: MAY: Code-Coverage
Submitted-with: MAY: Code-Review: Gerrit User 1526622 <1526622@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Submitted-with: MAY: Commit-Queue
Submitted-with: MAY: Feels
Submitted-with: MAY: Bot-Commit
Submitted-with: MAY: Owners-Override
Submitted-with: MAY: Lint
Submitted-with: OK
Submitted-with: Rule-Name: Code-Owners
Base: 28ebe5d0b0c8e30fa1a9c60f03e411086c00ad3d
Ours: c69ce7995ce5cb6524ddb14c3214ea36e9d0f065
Theirs: 28ebe5d0b0c8e30fa1a9c60f03e411086c00ad3d
Merge-Strategy: simple-two-way-in-core
Contains-Conflicts: false
Attention: {"person_ident":"Gerrit User 1002030 \u003c1002030@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"Change was submitted"}
Attention: {"person_ident":"Gerrit User 1001562 \u003c1001562@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"Change was submitted"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"Change was submitted"}
Attention: {"person_ident":"Gerrit User 1178490 \u003c1178490@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"Change was submitted"}
2025-10-16 12:20:40 -07:00
Gerrit User 1115898
b108370727 Update patch set 8
Patch-set: 8
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: SUBM=+1, 461e17e5c39889bf30ae0684c46c4b66d44666eb
2025-10-16 12:20:40 -07:00
Gerrit User 1526622
fea29ef4da Update patch set 8
Patch Set 8: Code-Review+1

Patch-set: 8
Reviewer: Gerrit User 1526622 <1526622@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Code-Review=+1, a3d05c952a018dd47121d94fe4f082bedf64c2c4
2025-10-16 11:51:20 -07:00
2 changed files with 229 additions and 0 deletions

View File

@ -51,6 +51,60 @@
"parentUuid": "052132b8_abef1ba2",
"revId": "57748f441f90326314c24fe894b1a03924db8275",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": true,
"key": {
"uuid": "925a0594_608639db",
"filename": "README.chromium",
"patchSetId": 5
},
"lineNbr": 3,
"author": {
"id": 1001562
},
"writtenOn": "2025-10-16T20:15:32Z",
"side": 1,
"message": "This is not done. Please modify the version in include/libyuv/version.h:\n\n```\ndiff --git a/include/libyuv/version.h b/include/libyuv/version.h\nindex 52f5a7cd..7c39017f 100644\n--- a/include/libyuv/version.h\n+++ b/include/libyuv/version.h\n@@ -11,6 +11,6 @@\n #ifndef INCLUDE_LIBYUV_VERSION_H_\n #define INCLUDE_LIBYUV_VERSION_H_\n \n-#define LIBYUV_VERSION 1920\n+#define LIBYUV_VERSION 1921\n \n #endif // INCLUDE_LIBYUV_VERSION_H_\n```",
"parentUuid": "f6a98f82_a5f0ff4d",
"revId": "57748f441f90326314c24fe894b1a03924db8275",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "8d7e88fc_35d32979",
"filename": "README.chromium",
"patchSetId": 5
},
"lineNbr": 3,
"author": {
"id": 1115898
},
"writtenOn": "2025-10-16T20:18:54Z",
"side": 1,
"message": "Acknowledged. The internal version is still up for review, so we can do some followup there",
"parentUuid": "925a0594_608639db",
"revId": "57748f441f90326314c24fe894b1a03924db8275",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "a94d35b5_8b840878",
"filename": "README.chromium",
"patchSetId": 5
},
"lineNbr": 3,
"author": {
"id": 1001562
},
"writtenOn": "2025-10-16T20:28:43Z",
"side": 1,
"message": "I converted this patch to a CL:\nhttps://chromium-review.googlesource.com/c/libyuv/libyuv/+/7050411",
"parentUuid": "8d7e88fc_35d32979",
"revId": "57748f441f90326314c24fe894b1a03924db8275",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}

View File

@ -17,5 +17,180 @@
"revId": "c69ce7995ce5cb6524ddb14c3214ea36e9d0f065",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
],
"submitRequirementResults": [
{
"submitRequirement": {
"name": "Admin-Approval",
"description": {
"value": "Changes to refs/meta/config must be approved by a git admin."
},
"applicabilityExpression": {
"value": {
"expressionString": "branch:refs/meta/config"
}
},
"submittabilityExpression": {
"expressionString": "(uploaderin:mdb/chrome-git-admins OR label:Code-Review\u003dMAX,group\u003dmdb/chrome-git-admins) AND label:Code-Review\u003dMAX,user\u003dnon_uploader AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {
"value": {
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
}
},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"branch:refs/meta/config"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"(uploaderin:mdb/chrome-git-admins OR label:Code-Review=MAX,group=mdb/chrome-git-admins) AND label:Code-Review=MAX,user=non_uploader AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"patchSetCommitId": "c69ce7995ce5cb6524ddb14c3214ea36e9d0f065",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Code-Review",
"description": {
"value": "If the author is a libyuv committer, code review is required from one other committer. Otherwise, code review is required from two committers."
},
"applicabilityExpression": {
"value": {
"expressionString": "-branch:refs/meta/config"
}
},
"submittabilityExpression": {
"expressionString": "((uploaderin:cria/project-libyuv-committers AND label:Code-Review\u003dMAX,user\u003dnon_uploader) OR label:Code-Review\u003dMAX,count\u003e\u003d2) AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {
"value": {
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
}
},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"-branch:refs/meta/config"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"((uploaderin:cria/project-libyuv-committers AND label:Code-Review=MAX,user=non_uploader) OR label:Code-Review=MAX,count>=2) AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX,user=non_uploader","uploaderin:cria/project-libyuv-committers"],"failingAtoms":["label:Code-Review=MIN","label:Code-Review=MAX,count>=2"],"atomExplanations":{"value":{"label:Code-Review=MIN":"","label:Code-Review=MAX,user=non_uploader":"","uploaderin:cria/project-libyuv-committers":"","label:Code-Review=MAX,count>=2":""}}}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Bot-Commit=+1","label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Bot-Commit=+1":"","label:Code-Review=MIN":""}}}
},
"patchSetCommitId": "c69ce7995ce5cb6524ddb14c3214ea36e9d0f065",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "No-Unresolved-Comments",
"description": {
"value": "Changes that have unresolved comments are not submittable. Unless overridden with Unresolved-Comment-Reason: \u003creason\u003e line in change message."
},
"applicabilityExpression": {
"value": {
"expressionString": "has:unresolved"
}
},
"submittabilityExpression": {
"expressionString": "-has:unresolved"
},
"overrideExpression": {
"value": {
"expressionString": "message:\"^.*Unresolved-Comment-Reason:.*\""
}
},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"],"atomExplanations":{"value":{"has:unresolved":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"message:\"^.*Unresolved-Comment-Reason:.*\""},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"patchSetCommitId": "c69ce7995ce5cb6524ddb14c3214ea36e9d0f065",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Review-Enforcement",
"description": {
"value": "Two trusted contributors must approve the change. Uploading the change or voting positively on Code-Review count as approval. For Google employees, using a trusted device is required (go/gerrit-onboarding#review-enforcement). For non-Google employees, ReAuth is required (https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gerrit_reauth.md)."
},
"applicabilityExpression": {
"value": {
"expressionString": "is:review-enforced_gerrit"
}
},
"submittabilityExpression": {
"expressionString": "is:review-enforcement-satisfied_gerrit"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforced_gerrit":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforcement-satisfied_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforcement-satisfied_gerrit":"Required approval count satisfied"}}}
},
"overrideExpressionResult": {},
"patchSetCommitId": "c69ce7995ce5cb6524ddb14c3214ea36e9d0f065",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Verified",
"description": {
"value": "Submit requirement for the \u0027Verified\u0027 label"
},
"applicabilityExpression": {
"value": {
"expressionString": "is:false"
}
},
"submittabilityExpression": {
"expressionString": "is:true"
},
"overrideExpression": {},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"],"atomExplanations":{"value":{"is:false":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {},
"patchSetCommitId": "c69ce7995ce5cb6524ddb14c3214ea36e9d0f065",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
}
]
}