mirror of
https://chromium.googlesource.com/libyuv/libyuv
synced 2025-12-14 23:49:57 +08:00
Compare commits
10 Commits
240e9f4fb3
...
1c859df4cc
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
1c859df4cc | ||
|
|
716e006101 | ||
|
|
6849c6f266 | ||
|
|
658cf9586f | ||
|
|
28a33c553c | ||
|
|
986d8f1434 | ||
|
|
e0e1fca1be | ||
|
|
de90b06033 | ||
|
|
9fb31b8282 | ||
|
|
36bb2c2b14 |
157
81ea995bf65ed1d0dee138745bb7c002142ba6e6
Normal file
157
81ea995bf65ed1d0dee138745bb7c002142ba6e6
Normal file
@ -0,0 +1,157 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e975cdf3_63b02814",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1571352
|
||||
},
|
||||
"writtenOn": "2024-12-12T11:05:09Z",
|
||||
"side": 1,
|
||||
"message": "(rebased)",
|
||||
"revId": "81ea995bf65ed1d0dee138745bb7c002142ba6e6",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
}
|
||||
],
|
||||
"submitRequirementResults": [
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Code-Review",
|
||||
"description": {
|
||||
"value": "If the author is a libyuv committer, code review is required from one other committer. Otherwise, code review is required from two committers."
|
||||
},
|
||||
"applicabilityExpression": {},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "((uploaderin:cria/project-libyuv-committers AND label:Code-Review\u003dMAX,user\u003dnon_uploader) OR label:Code-Review\u003dMAX,count\u003e\u003d2) AND -label:Code-Review\u003dMIN"
|
||||
},
|
||||
"overrideExpression": {
|
||||
"value": {
|
||||
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
|
||||
}
|
||||
},
|
||||
"allowOverrideInChildProjects": true
|
||||
},
|
||||
"applicabilityExpressionResult": {},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"((uploaderin:cria/project-libyuv-committers AND label:Code-Review=MAX,user=non_uploader) OR label:Code-Review=MAX,count>=2) AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX,user=non_uploader","uploaderin:cria/project-libyuv-committers"],"failingAtoms":["label:Code-Review=MIN","label:Code-Review=MAX,count>=2"]}
|
||||
},
|
||||
"overrideExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Bot-Commit=+1","label:Code-Review=MIN"]}
|
||||
},
|
||||
"patchSetCommitId": "81ea995bf65ed1d0dee138745bb7c002142ba6e6",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "No-Unresolved-Comments",
|
||||
"description": {
|
||||
"value": "Changes that have unresolved comments are not submittable. Unless overridden with Unresolved-Comment-Reason: \u003creason\u003e line in change message."
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "has:unresolved"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "-has:unresolved"
|
||||
},
|
||||
"overrideExpression": {
|
||||
"value": {
|
||||
"expressionString": "message:\"^.*Unresolved-Comment-Reason:.*\""
|
||||
}
|
||||
},
|
||||
"allowOverrideInChildProjects": false
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"]}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
|
||||
},
|
||||
"overrideExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"message:\"^.*Unresolved-Comment-Reason:.*\""},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
|
||||
},
|
||||
"patchSetCommitId": "81ea995bf65ed1d0dee138745bb7c002142ba6e6",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Review-Enforcement",
|
||||
"description": {
|
||||
"value": "Two Google employees must approve the change. Uploading the change or voting positively on Code-Review count as approval. Using a trusted device is required, see go/gerrit-onboarding#review-enforcement."
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "is:review-enforced_gerrit"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "is:review-enforcement-satisfied_gerrit"
|
||||
},
|
||||
"overrideExpression": {},
|
||||
"allowOverrideInChildProjects": false
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[]}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
|
||||
},
|
||||
"overrideExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:review-enforcement-satisfied_gerrit"]}
|
||||
},
|
||||
"patchSetCommitId": "81ea995bf65ed1d0dee138745bb7c002142ba6e6",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {
|
||||
"value": true
|
||||
}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Verified",
|
||||
"description": {
|
||||
"value": "Submit requirement for the \u0027Verified\u0027 label"
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "is:false"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "is:true"
|
||||
},
|
||||
"overrideExpression": {},
|
||||
"allowOverrideInChildProjects": true
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"]}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
|
||||
},
|
||||
"overrideExpressionResult": {},
|
||||
"patchSetCommitId": "81ea995bf65ed1d0dee138745bb7c002142ba6e6",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
}
|
||||
]
|
||||
}
|
||||
@ -16,6 +16,59 @@
|
||||
"message": "(this needs all of the earlier commits in the chain to be committed first)",
|
||||
"revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "b26ed1c6_e79a978d",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1115898
|
||||
},
|
||||
"writtenOn": "2024-12-12T09:33:50Z",
|
||||
"side": 1,
|
||||
"message": "theres pros and cons to this approach, but the end result is roughly 4x less code, so thats a win.\nIts a little hard to see how the macros piece together into a row function because they are far away from the wrapper. If each macro is basically only used once, it may be easier to understand it if its just above the function?",
|
||||
"revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "428cf28e_d73d5563",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1571352
|
||||
},
|
||||
"writtenOn": "2024-12-12T11:00:04Z",
|
||||
"side": 1,
|
||||
"message": "I\u0027ve moved a couple of macros above their usage, however most of the READ and conversion macros are used in multiple places so I think it makes more sense to keep them together since the register passing conventions between macros is pretty similar.",
|
||||
"parentUuid": "b26ed1c6_e79a978d",
|
||||
"revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "960e43ec_4c517a9a",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1115898
|
||||
},
|
||||
"writtenOn": "2024-12-12T11:07:48Z",
|
||||
"side": 1,
|
||||
"message": "Sounds good.\nFeels like this could be done cleaner but if we figure something out it can be revisited.\nFor actual sve we may want to do a full port, or back port, and then come up with some calling code logic for when sve is faster than neon... e.g. if vl \u003e 128",
|
||||
"parentUuid": "428cf28e_d73d5563",
|
||||
"revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
}
|
||||
]
|
||||
}
|
||||
21
b20ec337d1b81b7d504ee2e2e4fccd21030c2bb6
Normal file
21
b20ec337d1b81b7d504ee2e2e4fccd21030c2bb6
Normal file
@ -0,0 +1,21 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "0225e5cf_82722beb",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1571352
|
||||
},
|
||||
"writtenOn": "2024-12-12T11:00:04Z",
|
||||
"side": 1,
|
||||
"message": "(rebased)",
|
||||
"revId": "b20ec337d1b81b7d504ee2e2e4fccd21030c2bb6",
|
||||
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
x
Reference in New Issue
Block a user