Compare commits

...

10 Commits

Author SHA1 Message Date
Gerrit User 1115898
1c859df4cc Create patch set 4
Change has been successfully rebased and submitted as 7fd0bd197ee458a1c81be975b15308728a523331

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.


Patch-set: 4
Patch-set-description: Rebase
Subject: [AArch64] Port YUVToRGB color conversions to SME
Status: merged
Commit: 7fd0bd197ee458a1c81be975b15308728a523331
Tag: autogenerated:gerrit:merged
Groups: 81ea995bf65ed1d0dee138745bb7c002142ba6e6
Label: Code-Review=+1, 5689d2288187ec97b38ca3dabbd4cc51e0d1ae40
Label: SUBM=+1, 58f82770fe5f12859263662e132e88df2d056ee4
Submission-id: 6087804
Submitted-with: OK
Submitted-with: Rule-Name: gerrit~DefaultSubmitRule
Submitted-with: MAY: Auto-Submit
Submitted-with: MAY: Code-Coverage
Submitted-with: MAY: Code-Review: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Submitted-with: MAY: Commit-Queue
Submitted-with: MAY: Feels
Submitted-with: MAY: Bot-Commit
Submitted-with: MAY: Owners-Override
Submitted-with: OK
Submitted-with: Rule-Name: Code-Owners
Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"Change was submitted"}
2024-12-12 03:07:54 -08:00
Gerrit User 1115898
716e006101 Update patch set 3
Patch-set: 3
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: SUBM=+1, 218bd43a4c64bf6da591ff5a7dea78f21dea1833
2024-12-12 03:07:54 -08:00
Gerrit User 1115898
6849c6f266 Update patch set 3
Patch-set: 3
Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
2024-12-12 03:07:48 -08:00
Gerrit User 1115898
658cf9586f Update patch set 2
Patch Set 2: Code-Review+1

(1 comment)

Patch-set: 2
Label: Code-Review=+1, 3e9b4c2b386960f2482c29d6218822353181a7a8
2024-12-12 03:07:48 -08:00
Gerrit User 1571352
28a33c553c Update patch set 3
Patch Set 3:

(1 comment)

Patch-set: 3
2024-12-12 03:05:09 -08:00
Gerrit User 1571352
986d8f1434 Create patch set 3
Uploaded patch set 3: Patch Set 2 was rebased.

Copied Votes:
* Code-Review+1 by <GERRIT_ACCOUNT_1115898> (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR **changekind:TRIVIAL_REBASE** OR (**has:unchanged-files** AND **uploaderin:cria/project-libyuv-committers**) OR is:MIN")


Patch-set: 3
Subject: [AArch64] Port YUVToRGB color conversions to SME
Commit: 81ea995bf65ed1d0dee138745bb7c002142ba6e6
Tag: autogenerated:gerrit:newPatchSet
Groups: 81ea995bf65ed1d0dee138745bb7c002142ba6e6
Copied-Label: Code-Review=+1, 11a25eabe9a1628a6caed7fe7319ef342a392fa8 Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
2024-12-12 03:04:44 -08:00
Gerrit User 1571352
e0e1fca1be Update patch set 2
Patch Set 2:

(2 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1571352\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1526622 \u003c1526622@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1571352\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1571352\u003e replied on the change"}
2024-12-12 03:00:04 -08:00
Gerrit User 1571352
de90b06033 Create patch set 2
Uploaded patch set 2.

Copied Votes:
* Code-Review+1 by <GERRIT_ACCOUNT_1115898> (copy condition: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR (**has:unchanged-files** AND **uploaderin:cria/project-libyuv-committers**) OR is:MIN")


Patch-set: 2
Subject: [AArch64] Port YUVToRGB color conversions to SME
Commit: b20ec337d1b81b7d504ee2e2e4fccd21030c2bb6
Tag: autogenerated:gerrit:newPatchSet
Groups: 0ac245902e4cbe892c15f87c0ed905b19ffd097d
Copied-Label: Code-Review=+1, 11a25eabe9a1628a6caed7fe7319ef342a392fa8 Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
2024-12-12 02:54:37 -08:00
Gerrit User 1115898
9fb31b8282 Update patch set 1
Patch Set 1: Code-Review+1

Patch-set: 1
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Code-Review=+1, 11a25eabe9a1628a6caed7fe7319ef342a392fa8
2024-12-12 01:33:56 -08:00
Gerrit User 1115898
36bb2c2b14 Update patch set 1
Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
2024-12-12 01:33:50 -08:00
3 changed files with 231 additions and 0 deletions

View File

@ -0,0 +1,157 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "e975cdf3_63b02814",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 1571352
},
"writtenOn": "2024-12-12T11:05:09Z",
"side": 1,
"message": "(rebased)",
"revId": "81ea995bf65ed1d0dee138745bb7c002142ba6e6",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
],
"submitRequirementResults": [
{
"submitRequirement": {
"name": "Code-Review",
"description": {
"value": "If the author is a libyuv committer, code review is required from one other committer. Otherwise, code review is required from two committers."
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "((uploaderin:cria/project-libyuv-committers AND label:Code-Review\u003dMAX,user\u003dnon_uploader) OR label:Code-Review\u003dMAX,count\u003e\u003d2) AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {
"value": {
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
}
},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"((uploaderin:cria/project-libyuv-committers AND label:Code-Review=MAX,user=non_uploader) OR label:Code-Review=MAX,count>=2) AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX,user=non_uploader","uploaderin:cria/project-libyuv-committers"],"failingAtoms":["label:Code-Review=MIN","label:Code-Review=MAX,count>=2"]}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Bot-Commit=+1","label:Code-Review=MIN"]}
},
"patchSetCommitId": "81ea995bf65ed1d0dee138745bb7c002142ba6e6",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "No-Unresolved-Comments",
"description": {
"value": "Changes that have unresolved comments are not submittable. Unless overridden with Unresolved-Comment-Reason: \u003creason\u003e line in change message."
},
"applicabilityExpression": {
"value": {
"expressionString": "has:unresolved"
}
},
"submittabilityExpression": {
"expressionString": "-has:unresolved"
},
"overrideExpression": {
"value": {
"expressionString": "message:\"^.*Unresolved-Comment-Reason:.*\""
}
},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"]}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"message:\"^.*Unresolved-Comment-Reason:.*\""},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
},
"patchSetCommitId": "81ea995bf65ed1d0dee138745bb7c002142ba6e6",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Review-Enforcement",
"description": {
"value": "Two Google employees must approve the change. Uploading the change or voting positively on Code-Review count as approval. Using a trusted device is required, see go/gerrit-onboarding#review-enforcement."
},
"applicabilityExpression": {
"value": {
"expressionString": "is:review-enforced_gerrit"
}
},
"submittabilityExpression": {
"expressionString": "is:review-enforcement-satisfied_gerrit"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[]}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:review-enforcement-satisfied_gerrit"]}
},
"patchSetCommitId": "81ea995bf65ed1d0dee138745bb7c002142ba6e6",
"legacy": {
"value": false
},
"forced": {},
"hidden": {
"value": true
}
},
{
"submitRequirement": {
"name": "Verified",
"description": {
"value": "Submit requirement for the \u0027Verified\u0027 label"
},
"applicabilityExpression": {
"value": {
"expressionString": "is:false"
}
},
"submittabilityExpression": {
"expressionString": "is:true"
},
"overrideExpression": {},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"]}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "81ea995bf65ed1d0dee138745bb7c002142ba6e6",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
}
]
}

View File

@ -16,6 +16,59 @@
"message": "(this needs all of the earlier commits in the chain to be committed first)",
"revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "b26ed1c6_e79a978d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1115898
},
"writtenOn": "2024-12-12T09:33:50Z",
"side": 1,
"message": "theres pros and cons to this approach, but the end result is roughly 4x less code, so thats a win.\nIts a little hard to see how the macros piece together into a row function because they are far away from the wrapper. If each macro is basically only used once, it may be easier to understand it if its just above the function?",
"revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "428cf28e_d73d5563",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1571352
},
"writtenOn": "2024-12-12T11:00:04Z",
"side": 1,
"message": "I\u0027ve moved a couple of macros above their usage, however most of the READ and conversion macros are used in multiple places so I think it makes more sense to keep them together since the register passing conventions between macros is pretty similar.",
"parentUuid": "b26ed1c6_e79a978d",
"revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "960e43ec_4c517a9a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1115898
},
"writtenOn": "2024-12-12T11:07:48Z",
"side": 1,
"message": "Sounds good.\nFeels like this could be done cleaner but if we figure something out it can be revisited.\nFor actual sve we may want to do a full port, or back port, and then come up with some calling code logic for when sve is faster than neon... e.g. if vl \u003e 128",
"parentUuid": "428cf28e_d73d5563",
"revId": "b119232c3dcd49bc54f76c732ec21d0ed60617bc",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "0225e5cf_82722beb",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1571352
},
"writtenOn": "2024-12-12T11:00:04Z",
"side": 1,
"message": "(rebased)",
"revId": "b20ec337d1b81b7d504ee2e2e4fccd21030c2bb6",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
]
}