Frank Barchard
4f4e1ac553
Fix 2 failing golden tests
...
- Add ifdef for LIBYUV_UNLIMITED_DATA
Fixed by Gemini just telling it how to build and run the test and to fix it.
Bug: libyuv:353545922
Change-Id: I117a25b75b9616ee2ce6122aa163c2085ed4dc7d
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7742120
Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
2026-04-09 11:51:13 -07:00
Sam Maier
e3ceea1e67
Forward-declare ArgbConstants in convert.h to fix visibility error
...
The libyuv into Chromium roller is currently broken, see bug 500795092.
This change adds a forward declaration for struct ArgbConstants in
include/libyuv/convert.h. This resolves a -Wvisibility error where the
struct was being declared within a function prototype, making it
invisible outside that scope and breaking automated binding generation
(e.g., for crabbyavif).
Verified building crabbyavif_libyuv_bindings locally and this patch
fixed it.
Bug: 500795092
Change-Id: Ie0126650ab346940f4610bd4d2e8a5b3ef9ce103
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7739974
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
2026-04-09 08:53:56 -07:00
Frank Barchard
4c3d7d517a
ARGBToUV444 for AVX512
...
1.27x faster on AMD Zen5 (turin)
Now AVX512
perf record ./libyuv_test '--gunit_filter=*ARGBToI444_Opt' --libyuv_width=1280 --libyuv_height=720 --libyuv_repeat=10000 --libyuv_flags=-1 --libyuv_cpu_info=-1
[ OK ] LibYUVConvertTest.ARGBToI444_Opt (1071 ms)
Overhead Symbol
53.49% ARGBToYRow_AVX2
44.70% ARGBToUV444Row_AVX512BW
Was AVX2
[ OK ] LibYUVConvertTest.ARGBToI444_Opt (1369 ms)
61.06% ARGBToUV444Row_AVX2
37.67% ARGBToYRow_AVX2
Bug: libyuv:42280902
Change-Id: I306fbac656d6f7834ce1559e86d01eb34931ec3c
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7738362
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
2026-04-08 19:25:41 -07:00
Sam Maier
7903a6c632
Fix deprecated usage of strtok
...
The latest Android NDK marks strtok as deprecated and suggests using
strtok_r instead.
Bug: 477295731
Change-Id: I2b20a2ae0a9e19ec93e31669ec380802e6902090
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7739107
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2026-04-08 11:34:51 -07:00
Dale Curtis
1170363ce5
Add Gemini implementation for NEON32 RGB to YUV matrix operations
...
These are about 25% faster than the C versions.
Bug: libyuv:42280902
Change-Id: I8b298670ee5f3ed5db35527fc41d6d9a51b020a1
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7573682
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
2026-03-23 16:30:44 -07:00
Frank Barchard
4183733af5
Rename MergeUVRow_ variable to MergeUVRow
...
Bug: libyuv:42280902
Change-Id: I9935bf958b901ddf84cf91b2097c8cd5d6efadde
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7683070
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
2026-03-18 17:18:25 -07:00
Dale Curtis
b1cacfb38f
Unify X86/X64 versions of ARGBToI4xxMatrix functions
...
Change-Id: Iead13414414543e5f10ba9ba47a6ceaeb3113dee
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7562443
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Wan-Teh Chang <wtc@google.com>
2026-03-18 16:27:07 -07:00
Dale Curtis
f69a479f04
Add ARGBToNV12Matrix implementation
...
This one reuses the SIMD implementations for MergeUVRow_ from the
existing ARGBToNV12 functions.
Bug: libyuv:42280902
Change-Id: If0a4be133d657ed0262f29fdd568dac90b49636c
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7564317
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
2026-03-18 16:26:59 -07:00
Dale Curtis
2c21d57319
Add ABGR versions of the ArgbConstants structures
...
This allows for ABGR conversion using the same methods
Bug: libyuv:42280902
Change-Id: I5566e3150b30573a2326a900ce31ab095f8935f9
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7564316
Reviewed-by: richard winterton <rrwinterton@gmail.com>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Wan-Teh Chang <wtc@google.com>
2026-03-17 17:28:51 -07:00
Dale Curtis
30809ff64a
Add ARGBToI4xxMatrix variants
...
This was implemented by Gemini followed by manual review and some
tweaking for style. The 601 and JPEG constants are fully verified
against the existing non-matrix implementations. On x86 the C-only
versions appear to be about 25% slower than the optimized ones.
Bug: libyuv:42280902
Change-Id: Ia5b7cb499bad5c76faec53f36086ebb18f2b530f
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7512030
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
2026-03-04 10:55:06 -08:00
Victor Hugo Vianna Silva
6067afde56
Roll chromium_revision 30d4d9c779..2fec1883d8 (1554090:1584384)
...
Change log: 30d4d9c779..2fec1883d830d4d9c779..2fec1883d8daa16e7b52..bc3e93b3c4eca5f0685c..6a18683f55bf756663c3..5d7abd8337e8bfcfdf9d..d274a4df834471edb07a..51ac942dd6https://chromium.googlesource.com/catapult.git/+log/eda8d2eec9..5203599120
* src/third_party/compiler-rt/src: 03f50e54e9..996704b46785116f1710..ccffb577777d936359a2..fa2908bf1607572e7b16..7ab65651ae83a8520807..8f11bb1d446383cf609c..6bb85251a888fc07ed14..17ccf7d1103b327fec43..d38523b674e7aec59850..972a15cedd39bc80757f..73a128cf7330d4d9c779..2fec1883d830d4d9c779..2fec1883d8https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7572311
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
2026-02-12 23:42:06 -08:00
Jordan
917276084a
Set Update Mechanism: Manual
...
This CL sets the Update Mechanism to Manual in README files.
Bug: 445311061
Change-Id: I4df6c5815b85c04b047b39b4352ba43789702d26
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7512992
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Owners-Override: Jordan Brown <rop@google.com>
2026-01-28 00:04:45 -08:00
Jeremy Leconte
f95782d01c
Manual roll - update some package names
...
Bug: None
Change-Id: I23a60ccd36f9cb5d335c7c073ccf894002468edd
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7510834
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2026-01-26 23:22:22 -08:00
Valentin Haudiquet
022efdb0b7
RVV: Enable RVV on GCC
...
GCC now supports vector segment load and store, which
was previously missing; and the reason why it was disabled.
Change-Id: I923fd8a15476de8dcc2103bb8335d4fcc3ca96a9
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7241606
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
2026-01-06 11:16:24 -08:00
Nico Weber
821b9c5de1
Simplify libyuv build files now that neon is required on arm
...
No intended behavior change.
Bug: 469092869
Change-Id: Iedaf1163bc0f8507174b571bad9a4a16be5e5777
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7276827
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2026-01-05 10:28:19 -08:00
Victor Hugo Vianna Silva
deeb764bb9
Roll src/build/ 3c58005ad..c53d22a39 (15 commits)
...
3c58005adf..c53d22a398#2 ): "Make test APK the default browser app if it has APP_BROWSER category"
2025-12-05 machenbach [build] Enable building arm with coverage instrumentation
2025-12-05 brunobraga [AutofillAi - M4] Add required java classes for c++ communication
2025-12-04 zijiehe [fuchsia] --bp-compression-sort=function in size-optimized
2025-12-04 ajgo Delayload secur32, winhttp, winspool & wintrust
2025-12-04 msta Remove extern_c from clang modules.
2025-12-04 anandrv [base/android] Add location attribution to ThreadUtils methods
Created with:
roll-dep src/build
Change-Id: Iced6f760cae459eaa6351e5d8238f8d25bb3980f
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7241672
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
2025-12-10 10:45:00 -08:00
Victor Hugo Vianna Silva
74ea9ed7c9
Roll chromium_revision 68659bfa38..30d4d9c779 (1531610:1554090)
...
Change log: 68659bfa38..30d4d9c77968659bfa38..30d4d9c779b2e55d8d32..3c58005adf28a4e2e3dc..eca5f0685c82e655421c..bf756663c34c3aba1a9e..e8bfcfdf9d1920e63dfd..4471edb07ahttps://chromium.googlesource.com/catapult.git/+log/1c28f8a288..eda8d2eec9
* src/third_party/compiler-rt/src: d7392a1ed4..03f50e54e9ddb97c1c77..85116f1710e17e37a115..4fe3307fb2ff35c4f9df..a86a32e67b1af2c657e2..07572e7b168e720a3a3a..83a8520807e14cbfaa85..6383cf609c224761f783..88fc07ed14b3af9aedd6..3b327fec43e2c93c3498..af5eeeb05461c4644171..e7aec598506c975b3dc5..39bc80757f68659bfa38..30d4d9c77968659bfa38..30d4d9c779https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7228726
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-12-04 11:11:16 -08:00
Victor Hugo Vianna Silva
4825d9b29e
Use default xcode version in libyuv
...
Following crrev.com/c/7171485, libyuv should be able to rely on
the default xcode version of the bots.
Bug: 461757070
Change-Id: Iecc34bb0b0476b61be1d9dfd51904396913c85f4
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7177782
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-11-24 07:54:14 -08:00
Victor Hugo Vianna Silva
068c9f2f64
Upgrade linux bots from ubuntu 22.04 to 24.04
...
Bug: 459541007
Change-Id: I0ff7ecb4400f82ef7cff93ec98fe16b47ded062b
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7132084
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
2025-11-12 17:34:13 -08:00
Frank Barchard
900da61d3c
Experimental SVE FMMLA detect
...
Detect if arm cpu support FMMLA instruction
Bug: None
Change-Id: Ia7b83bf2735ddeeb8a85da44177e708c34e4b1fb
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7085486
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
2025-10-27 14:34:55 -07:00
Frank Barchard
500f45652c
For for ARM32 build when built with __SOFTFP__
...
planar_test.cc was
Error: selected processor does not support `vmrs r3,fpscr' in ARM mode
Error: selected processor does not support `vmsr fpscr,r3' in ARM mode
Bug: None
Change-Id: I2ee0e7191c372277901c94e29d9ed91bbac71af2
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7063737
Reviewed-by: Justin Green <greenjustin@google.com>
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
2025-10-20 11:54:25 -07:00
Victor Hugo Vianna Silva
e49099d8e1
Roll chromium_revision 89484fe328..68659bfa38 (1529283:1531610)
...
Change log: 89484fe328..68659bfa3889484fe328..68659bfa3802d98ae43e..b2e55d8d320e7d35148b..28a4e2e3dc248952acfb..82e655421c29a6541860..4c3aba1a9ec78db06f7e..1920e63dfdhttps://chromium.googlesource.com/catapult.git/+log/2f71f97f0b..1c28f8a288
* src/third_party/compiler-rt/src: 3a23fdd905..d7392a1ed4f39ee3c673..ddb97c1c777917641ff9..e17e37a115dc1441a0c2..1af2c657e2da8737e079..224761f7838ab123717d..b3af9aedd6c7b77bb56a..6c975b3dc589484fe328..68659bfa38https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7054948
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
2025-10-17 15:42:29 -07:00
Victor Hugo Vianna Silva
df79165ad2
Roll chromium_revision 9dbf00e283..89484fe328 (1465343:1529283)
...
The goal is to roll crrev.com/c/7005224. This roll required replacing
use of src/tools/clang/scripts/update.py with explicit GCS dependencies,
in order to fetch llvm-otool for Mac.
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/libyuv/DEPS;l=1566-1572;drc=738a53ce271acc8cde81798bbdd22dca2fde81a3
[2] https://source.chromium.org/chromium/chromium/src/+/main:DEPS;l=856-1017;drc=a478ffb982d78f41d22a7daa80771d836bca043a
Change log: 9dbf00e283..89484fe3289dbf00e283..89484fe3287907108fc6..02d98ae43e813bee86ee..0e7d35148bc61efe1d6d..248952acfb739fbc1a64..29a6541860a0168b392b..c78db06f7ehttps://chromium.googlesource.com/catapult.git/+log/938fc9953b..2f71f97f0b
* src/third_party/clang-format/script: 37f6e68a10..c2725e06229c6d38aa28..3a23fdd905e0ece52cfb..f39ee3c67309ffd00153..7917641ff99f83bbbe64..7d936359a2b929596bae..ff35c4f9dfa01c02c9d4..dc1441a0c29810fb23f6..8e720a3a3a8575f4ae4f..da8737e0790d758dd57f..0928ad0d259c3ae3120f..8ab123717dhttps://chromium.googlesource.com/linux-syscall-support.git/+log/ed31caa60f..29164a80da
* src/third_party/nasm: 9f916e90e6..e2c93c3498c84a140c93..61c4644171ae54c8a35f..c7b77bb56a9dbf00e283..89484fe3289dbf00e283..89484fe328https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7036460
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
2025-10-17 11:55:00 -07:00
Mark Zhuang
e237e8d7fb
RVV: Enable some function for intrinsic >= v1.0
...
According to README of rvv-intrinsic-doc,
Clang 19 and GCC 14 supports the v1.0 version.
But __riscv_v_intrinsic is 12000 on Clang 19,
so need Clang >= 20 to test this patch.
I test it with Clang 21.
Change-Id: I0e75efcdab3e7bc0ce1acd19eca3568b47c84cbf
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6995438
Reviewed-by: Justin Green <greenjustin@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2025-10-17 11:44:14 -07:00
Victor Hugo Vianna Silva
738a53ce27
Fix mac_asan bot by using right architecture for dsymutil
...
This broke in https://crrev.com/c/7041203 when we switched mac_asan
to use arm64, but didn't change the dsymutil binary. Let's fix by
adopting the approach of chromium/src, which works for both archs.
https://source.chromium.org/chromium/chromium/src/+/main:DEPS;l=4243-4267;drc=bd6571ed43a1025fa5122e31db929ccb69df6ce1
Bug: 448679376
Change-Id: I7f43b4ce7ad3a3946080f4c5bcbca32d6cbc4c5c
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7050423
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2025-10-16 15:01:43 -07:00
Victor Hugo Vianna Silva
1f62f14950
Update xcode in bots (3rd attempt)
...
The .cfg file in https://crrev.com/c/7043382 wasn't up-to-date for
some reason. I verified this CL indeed updates xcode in the iOS
bot. mac_asan is still broken for now.
- led get-builder "libyuv/try/ios_arm64_rel" > config.json
- Edit config.json to include the snippet below in its properties.
- cat config.json | led launch
https://ci.chromium.org/ui/p/libyuv/builders/ci.shadow/iOS%20ARM64%20Release/1/overview
```
"$depot_tools/osx_sdk": {
"sdk_version": "17a324"
},
```
Bug: 448679376
Change-Id: Ie15e6164246611a5a1c06357307be512da0ff902
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7046681
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
2025-10-16 14:28:05 -07:00
Wan-Teh Chang
fcd7060e0d
Bump LIBYUV_VERSION for removal of MIPS support
...
Bump LIBYUV_VERSION to 1921. Missed in
https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7045953 .
Bug: 434383432
Change-Id: If51122f1b744718551b0b601ead7cacb8c46c20d
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7050411
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2025-10-16 13:32:52 -07:00
Victor Hugo Vianna Silva
a5acc0bea9
Update xcode in bots (2nd attempt)
...
Turns out there are 2 ways to specify an xcode version on the bots.
https://crrev.com/c/7037174 used a way that differs from the one
currently in place in the bot recipe [1]. See thread [2] for more
details. This CL reverts most xcode changes from the original CL
and adopts an approach similar to https://crrev.com/i/8594830
instead.
I would have preferred to verify this CL works ahead of landing
with led, but I don't have permission [3]. No-Try: True is added
because mac_asan is busted https://crrev.com/c/7045106 .
[1] https://source.chromium.org/chromium/infra/infra_superproject/+/main:build/recipes/recipes/libyuv/libyuv.py
[2] https://chat.google.com/room/AAAAzEuhg8A/S-r4vJCVnLY
[3] https://chat.google.com/room/AAAAzEuhg8A/S-r4vJCVnLY
No-Try: True
Bug: 448679376
Change-Id: I24609c820491f5bd93052687af8989f63172b144
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7043382
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-10-16 12:39:27 -07:00
Frank Barchard
2b4453d46f
Deprecate MIPS and MSA support.
...
- Remove *_msa.cc source files
- Update build files
- Update header references, planar ifdefs for row functions
- Update documentation on supported platforms
- Version bumped to 1921
- clang-format applied
Bug: 434383432
Change-Id: I072d6aac4956f0ed668e64614ac8557612171f76
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7045953
Reviewed-by: Justin Green <greenjustin@google.com>
2025-10-16 12:20:40 -07:00
Victor Hugo Vianna Silva
28ebe5d0b0
Fix led failing due to service account disallowed
...
Follow-up to https://crrev.com/c/7046060 .
Comparing the files below, we see the issue's root cause.
https://source.chromium.org/chromium/chromium/src/+/main:third_party/libyuv/infra/config/cr-buildbucket.cfg;l=607-620;drc=110e00ea9693e9feed3f6bb49cf7a9497440bca1
https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/infra/config/generated/cr-buildbucket.cfg;l=2143-2154;drc=722572ab69816657492c1155dad7f99e3e2629ea
Bug: None
Change-Id: Iaf339950db4e8b414719057ae81ba5b850f0aace
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7050097
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2025-10-16 10:41:52 -07:00
Victor Hugo Vianna Silva
cd42708dac
Update instructions for fetching libyuv
...
`fetch libyuv` is supported since crrev.com/c/7036474.
No-Try: True
Change-Id: I526f873c80124977a5a7a192f41110f8f6c37e47
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7036475
Reviewed-by: Christoffer Dewerin <jansson@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-10-16 08:03:02 -07:00
Victor Hugo Vianna Silva
110e00ea96
Allow use of led via http://go/ciba
...
Users who have the "Chrome Build Access" in go/ciba can now use the
`led` CLI on libyuv bots. No-Try because the mac-asan bot is busted.
I will use this to test the CL below ahead of submission.
https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7043382
No-Try: True
Change-Id: I33b488406f342fac4ff33d02e2c70cef2e50233c
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7046060
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-10-16 05:57:31 -07:00
Victor Hugo Vianna Silva
613393324f
Fix CQ not finding Mac-15 x86_64 bots
...
https://crrev.com/c/7037174 took effect but now CQ finds no Mac-15
x86_64 bots [1]. Fix by switching to arm64.
This change lists "No-Try: True" because CQ is busted.
[1] https://ci.chromium.org/ui/p/libyuv/builders/try/ios_arm64/3589/infra
No-Try: True
Bug: chromium:448679376
Change-Id: I6b77ce004f8cbbe0ea5c434edd140dd1ece6a152
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7041203
Reviewed-by: Ben Weiss <bweiss@google.com>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Justin Green <greenjustin@google.com>
Reviewed-by: Wan-Teh Chang <wtc@google.com>
2025-10-14 10:22:16 -07:00
Victor Hugo Vianna Silva
69046a8ab0
Update Mac and Xcode version in bots
...
Bug: 448679376
Change-Id: I077cd31073889afe0519195a8c459570bc95e4a8
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7037174
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Christoffer Dewerin <jansson@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
2025-10-14 05:18:54 -07:00
Fumitoshi Ukai
f5c7d8a44d
use configure_reclient_cfgs instead of fetch_reclient_cfgs
...
fetch_reclient_cfgs was removed to configure_reclient_cfgs
https://source.chromium.org/chromium/chromium/src/+/main:buildtools/reclient_cfgs/fetch_reclient_cfgs.py
Change-Id: I701ec8774b33c07aacf2c7e6dc995d6a4e89d06c
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7005807
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Christoffer Dewerin <jansson@chromium.org>
2025-10-07 02:50:32 -07:00
Mirko Bonadei
0d8ed86032
Remove unused DEPS.
...
Bug: b/448783045
Change-Id: I4514e4ed7b5229d3fd26707452a4ffcead3890ac
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/7002766
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
2025-10-02 02:02:12 -07:00
Frank Barchard
94417b9d21
Pass rgbconstants via struct pointer instead of elements with m
...
Now 66 instructions
SYM ARGBToUVRow_SSSE3:
62ccd0: BASE push ebp
62ccd1: BASE mov ebp, esp
62ccd3: BASE push ebx
62ccd4: BASE push edi
62ccd5: BASE push esi
62ccd6: BASE and esp, 0xfffffffc
62ccd9: BASE sub esp, 0xc
62ccdc: BASE call 0x62cce1 <ARGBToUVRow_SSSE3+0x11>
62cce1: BASE pop eax
62cce2: BASE add eax, 0xe1c27
62cce8: BASE mov ecx, dword ptr [ebp+0xc]
62cceb: BASE mov edx, dword ptr [ebp+0x8]
62ccee: BASE mov esi, dword ptr [ebp+0x10]
62ccf1: BASE mov edi, dword ptr [ebp+0x18]
62ccf4: BASE mov dword ptr [esp+0x8], edi
62ccf8: BASE mov edi, dword ptr [ebp+0x14]
62ccfb: BASE lea ebx, ptr [eax-0x5ecf88]
62cd01: SSE2 movdqa xmm4, xmmword ptr [ebx]
62cd05: SSE2 movdqa xmm5, xmmword ptr [ebx+0x10]
62cd0a: SSE2 pcmpeqb xmm6, xmm6
62cd0e: SSSE3 pabsb xmm6, xmm6
62cd13: SSE2 movdqa xmm7, xmmword ptr [eax-0x5ecfa8]
62cd1b: BASE sub edi, esi
62cd1d: SSE2 movdqu xmm0, xmmword ptr [edx]
62cd21: SSE2 movdqu xmm1, xmmword ptr [edx+0x10]
62cd26: SSE2 movdqu xmm2, xmmword ptr [edx+ecx*1]
62cd2b: SSE2 movdqu xmm3, xmmword ptr [edx+ecx*1+0x10]
62cd31: SSSE3 pshufb xmm0, xmm7
62cd36: SSSE3 pshufb xmm1, xmm7
62cd3b: SSSE3 pshufb xmm2, xmm7
62cd40: SSSE3 pshufb xmm3, xmm7
62cd45: SSSE3 pmaddubsw xmm0, xmm6
62cd4a: SSSE3 pmaddubsw xmm1, xmm6
62cd4f: SSSE3 pmaddubsw xmm2, xmm6
62cd54: SSSE3 pmaddubsw xmm3, xmm6
62cd59: SSE2 paddw xmm0, xmm2
62cd5d: SSE2 paddw xmm1, xmm3
62cd61: SSE2 pxor xmm2, xmm2
62cd65: SSE2 psrlw xmm0, 0x1
62cd6a: SSE2 psrlw xmm1, 0x1
62cd6f: SSE2 pavgw xmm0, xmm2
62cd73: SSE2 pavgw xmm1, xmm2
62cd77: SSE2 packuswb xmm0, xmm1
62cd7b: SSE2 movdqa xmm2, xmm6
62cd7f: SSE2 psllw xmm2, 0xf
62cd84: SSE2 movdqa xmm1, xmm0
62cd88: SSSE3 pmaddubsw xmm1, xmm5
62cd8d: SSSE3 pmaddubsw xmm0, xmm4
62cd92: SSSE3 phaddw xmm0, xmm1
62cd97: SSE2 psubw xmm2, xmm0
62cd9b: SSE2 psrlw xmm2, 0x8
62cda0: SSE2 packuswb xmm2, xmm2
62cda4: SSE2 movd dword ptr [esi], xmm2
62cda8: SSE2 pshufd xmm2, xmm2, 0x55
62cdad: SSE2 movd dword ptr [esi+edi*1], xmm2
62cdb2: BASE lea edx, ptr [edx+0x20]
62cdb5: BASE lea esi, ptr [esi+0x4]
62cdb8: BASE sub dword ptr [esp+0x8], 0x8
62cdbd: BASE jnle 0x62cd1d <ARGBToUVRow_SSSE3+0x4d>
62cdc3: BASE lea esp, ptr [ebp-0xc]
62cdc6: BASE pop esi
62cdc7: BASE pop edi
62cdc8: BASE pop ebx
62cdc9: BASE pop ebp
62cdca: BASE ret
Was 68 instructions
ARGBToUVRow_SSSE3:
62ccd0: BASE push ebp
62ccd1: BASE mov ebp, esp
62ccd3: BASE push edi
62ccd4: BASE push esi
62ccd5: BASE and esp, 0xfffffff0
62ccd8: BASE sub esp, 0x30
62ccdb: BASE call 0x62cce0 <ARGBToUVRow_SSSE3+0x10>
62cce0: BASE pop eax
62cce1: BASE add eax, 0xe1c28
62cce7: BASE mov ecx, dword ptr [ebp+0xc]
62ccea: BASE mov edx, dword ptr [ebp+0x8]
62cced: BASE mov esi, dword ptr [ebp+0x10]
62ccf0: BASE mov edi, dword ptr [ebp+0x18]
62ccf3: BASE mov dword ptr [esp+0xc], edi
62ccf7: BASE mov edi, dword ptr [ebp+0x14]
62ccfa: SSE movaps xmm0, xmmword ptr [eax-0x5ecf88]
62cd01: SSE movaps xmmword ptr [esp+0x20], xmm0
62cd06: SSE movaps xmm0, xmmword ptr [eax-0x5ecf78]
62cd0d: SSE movaps xmmword ptr [esp+0x10], xmm0
62cd12: SSE2 movdqa xmm4, xmmword ptr [esp+0x20]
62cd18: SSE2 movdqa xmm5, xmmword ptr [esp+0x10]
62cd1e: SSE2 pcmpeqb xmm6, xmm6
62cd22: SSSE3 pabsb xmm6, xmm6
62cd27: SSE2 movdqa xmm7, xmmword ptr [eax-0x5ecfa8]
62cd2f: BASE sub edi, esi
62cd31: SSE2 movdqu xmm0, xmmword ptr [edx]
62cd35: SSE2 movdqu xmm1, xmmword ptr [edx+0x10]
62cd3a: SSE2 movdqu xmm2, xmmword ptr [edx+ecx*1]
62cd3f: SSE2 movdqu xmm3, xmmword ptr [edx+ecx*1+0x10]
62cd45: SSSE3 pshufb xmm0, xmm7
62cd4a: SSSE3 pshufb xmm1, xmm7
62cd4f: SSSE3 pshufb xmm2, xmm7
62cd54: SSSE3 pshufb xmm3, xmm7
62cd59: SSSE3 pmaddubsw xmm0, xmm6
62cd5e: SSSE3 pmaddubsw xmm1, xmm6
62cd63: SSSE3 pmaddubsw xmm2, xmm6
62cd68: SSSE3 pmaddubsw xmm3, xmm6
62cd6d: SSE2 paddw xmm0, xmm2
62cd71: SSE2 paddw xmm1, xmm3
62cd75: SSE2 pxor xmm2, xmm2
62cd79: SSE2 psrlw xmm0, 0x1
62cd7e: SSE2 psrlw xmm1, 0x1
62cd83: SSE2 pavgw xmm0, xmm2
62cd87: SSE2 pavgw xmm1, xmm2
62cd8b: SSE2 packuswb xmm0, xmm1
62cd8f: SSE2 movdqa xmm2, xmm6
62cd93: SSE2 psllw xmm2, 0xf
62cd98: SSE2 movdqa xmm1, xmm0
62cd9c: SSSE3 pmaddubsw xmm1, xmm5
62cda1: SSSE3 pmaddubsw xmm0, xmm4
62cda6: SSSE3 phaddw xmm0, xmm1
62cdab: SSE2 psubw xmm2, xmm0
62cdaf: SSE2 psrlw xmm2, 0x8
62cdb4: SSE2 packuswb xmm2, xmm2
62cdb8: SSE2 movd dword ptr [esi], xmm2
62cdbc: SSE2 pshufd xmm2, xmm2, 0x55
62cdc1: SSE2 movd dword ptr [esi+edi*1], xmm2
62cdc6: BASE lea edx, ptr [edx+0x20]
62cdc9: BASE lea esi, ptr [esi+0x4]
62cdcc: BASE sub dword ptr [esp+0xc], 0x8
62cdd1: BASE jnle 0x62cd31 <ARGBToUVRow_SSSE3+0x61>
62cdd7: BASE lea esp, ptr [ebp-0x8]
62cdda: BASE pop esi
62cddb: BASE pop edi
62cddc: BASE pop ebp
62cddd: BASE ret
62cdde: BASE int3
BUG=444157316
Change-Id: Iad044f851359f5b052091c7bdab9b96946fc3682
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6987370
Reviewed-by: Justin Green <greenjustin@google.com>
2025-09-29 12:34:36 -07:00
Daniel.L (Byoungchan Lee)
5b22f31cb5
Fix compilation issue for 32bit PIC build
...
Currently, ARGBToUVMatrixRow_AVX2 and ARGBToUVMatrixRow_SSSE3 fail to
compile with clang on 32bit PIC build with the error message: inline
assembly requires more registers than available
This is because in PIC code EBX is reserved for the GOT and with a frame
pointer EBP is also unavailable.
Fix this by copying the RGB-to-UV constants to stack locals first and
let the asm use simple stack-relative addressing.
Bug: 444157316
Change-Id: Ica90f0c35039303ecaa145534683f59659fb5d7f
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6980714
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: richard winterton <rrwinterton@gmail.com>
2025-09-25 13:49:02 -07:00
Frank Barchard
1b1c058787
ARGBToUV for SSE use pshufb/pmaddubsw
...
Was
ARGBToJ420_Opt (377 ms)
Now
ARGBToJ420_Opt (340 ms)
Bug: None
Change-Id: Iada2d6e9ecdb141b9e2acbdf343f890e4aaebe34
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6967754
Reviewed-by: Justin Green <greenjustin@google.com>
2025-09-19 12:39:39 -07:00
Mark Zhuang
d59fe1a2b8
docs: fix markdown indent
...
Change-Id: Ib3a7e04aa71fbf7e52fdffd7b5a767221defc030
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6954698
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-09-18 17:24:50 -07:00
Frank Barchard
7155afc5ca
ARGBToUV AVX2 for x86 32 bit
...
- Reduce to 10 ymm registers - 2 constants generated on the fly
Change-Id: Ib25a0cf7c93e5048270735410ccf6723b3949454
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6967319
Reviewed-by: richard winterton <rrwinterton@gmail.com>
2025-09-18 13:14:45 -07:00
Frank Barchard
142db12947
ARGBToUV use AVX2 for 64 bit x86
...
Skylake
Was ARGBToJ420_Opt (312 ms)
Now ARGBToJ420_Opt (242 ms)
Icelake
Was ARGBToJ420_Opt (302 ms)
Now ARGBToJ420_Opt (220 ms)
AMD Zen3 on Windows
Was ARGBToJ420_Opt (305 ms)
Now ARGBToJ420_Opt (216 ms)
32 bit x86 uses SSE
Now ARGBToJ420_Opt (326 ms)
MCA analysis of new AVX, SSE and old AVX
https://godbolt.org/z/37bdazWYr
Bug: None
Change-Id: I72f5504407751e164c3558aebe836dd15223d65f
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6957477
Reviewed-by: Justin Green <greenjustin@google.com>
2025-09-17 14:39:53 -07:00
Mark Zhuang
b33794a586
RVV: Don't disable all rvv optimize when RVV >= v0.12
...
Disabled since Patch v2 of
https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6385788
Change-Id: Id30a62c8f164830204dde02a443f5e4f04d757db
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6953818
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2025-09-16 18:17:02 -07:00
Frank Barchard
a61882c049
ARGBToUV AVX2 for x86_64
...
Icelake
Was SSSE3+SSSE3 ARGBToJ420_Opt (356 ms)
Was SSSE3+AVX2 ARGBToJ420_Opt (301 ms)
Now AVX2+AVX2 ARGBToJ420_Opt (227 ms)
Change-Id: I2cb427bc164b225b3ad4c5f43c09d6da6ca496d5
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6943036
Reviewed-by: richard winterton <rrwinterton@gmail.com>
2025-09-16 11:33:54 -07:00
Frank Barchard
0f795672ae
Reduce ARGBToUV SSSE3 register usage for clang build error on x64
...
Bug: 444157316
Change-Id: I2ae9f3dbfb373bb874a3d9699987f7d5b63f2610
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6937665
Reviewed-by: richard winterton <rrwinterton@gmail.com>
2025-09-10 18:40:06 -07:00
Xi Ruoyao
06a1c004bb
Revert "Enable explicit control over LoongArch LSX & LASX for GYP builds"
...
This reverts commit 6ecfe106c304d1eeaa31d1b29a42c58fb70d35ca.
This "explicit control" with -mlasx as the default is really surprising
and unfriendly to distro maintainers and/or downstream projects. They
already know using -m{no-,}l{a,}sx in CXXFLAGS to enable/disable the
LoongArch vector extensions, but this control does not respect those
flags already in the environment, forcing every distro and every
downstream project to wire an extra logic into their build system if
they need to change the default.
To make things worse, LSX is guaranteed to be available for LoongArch
desktop processors but LASX is not. Thus most downstream works will
indeed need to change the default for hardware compatibility.
"LASX is widely supported among LoongArch desktops and servers, and
performance is better than with LSX alone" is true, but in the future we
can make the use of LASX correctly guarded by runtime CPU feature check
to take the advantange without breaking the hardware compatibility.
No-Try: true
Change-Id: I43b31a139b106b7f6f8b6ca5dc04045633ea1989
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6772565
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2025-09-05 20:04:18 -07:00
yuanhecai
eb4e4736a4
loong64: UV subsample's 4-pixel rounding average and ARGBToJ444 fixed-point scaling
...
The UV subsample's 4-pixel rounding average and ARGBToJ444 fixed-point scaling
were updated in d32d19cc and c060118b. The LoongArch optimization is updated now.
Bug: 381138208
Change-Id: I3585d72564e4fffe514599b1a9b4fee8fbbd0266
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6878364
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-09-03 12:22:44 -07:00
Victor Hugo Vianna Silva
70458840c4
[libyuv] Bump vpython from 3.8 to 3.11
...
Also requires upgrading some packages.
Bug: 40249958
Change-Id: I3c57ddd746b4333923ea2dd14a140bc8b7e381db
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6909330
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-09-03 12:22:19 -07:00
Takuto Ikuta
c00b83884e
infra/config: Remove luci.recipes.use_python3 experiment
...
Python3 is used by default in recipes now and this config is not
necessary anymore.
Bug: 440235171
Change-Id: Ia7d2d54ca3afe25b43e8a1636d08507f709f0966
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6888293
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
2025-09-02 01:08:51 -07:00
Jeremy Leconte
36edc5fa8b
Fix assert(current_toolchain == default_toolchain) failure on win bots.
...
Bug: libyuv:440517010
Change-Id: Ida12cce239448dae40524b4b629981116eeadacd
Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/6904242
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
2025-09-01 07:05:21 -07:00
