Compare commits

...

13 Commits

Author SHA1 Message Date
Gerrit User 1115898
7d2b8786c1 Create patch set 2
Change has been successfully rebased and submitted as 2e65a61dffeb6ab9dd5dd363ccede11770957b73

Patch-set: 2
Patch-set-description: Rebase
Subject: AArch64: Avoid lane-indexed LD4 dependency in 32 bit transpose
Status: merged
Commit: 2e65a61dffeb6ab9dd5dd363ccede11770957b73
Tag: autogenerated:gerrit:merged
Groups: dc630852d7e90c27003ce0c7e322f7d02baff122
Label: Code-Review=+1, e46a2ba8817810636424e9fe68184ab1cb74eafa
Label: Code-Review=+1, 91ca46d38a5562689f334378dbb0b18ccca8c2d0 Gerrit User 1526622 <1526622@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Commit-Queue=0, c97523ee350c5207ed63f70be60c436e104b7efb
Label: SUBM=+1, 167be48d5118eac7f78c7fe6671d95a23ba61f07
Submission-id: 8669762
Submitted-with: OK
Submitted-with: Rule-Name: gerrit~DefaultSubmitRule
Submitted-with: MAY: SLSA-Policy-Verified
Submitted-with: MAY: Code-Review-Auto-Approval
Submitted-with: MAY: Auto-Submit
Submitted-with: MAY: Code-Coverage
Submitted-with: MAY: Code-Review: Gerrit User 1526622 <1526622@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Submitted-with: MAY: Commit-Queue
Submitted-with: MAY: Feels
Submitted-with: MAY: Owners-Override
Submitted-with: MAY: Lint
Submitted-with: MAY: Bot-Commit
Submitted-with: MAY: Pure-Revert
Submitted-with: MAY: Pure-Cherry-Pick
Submitted-with: MAY: Benign-Change
Submitted-with: OK
Submitted-with: Rule-Name: Code-Owners
Base: f249eaa72ffef5766df707bf90cc378243fbbcdd
Ours: dc630852d7e90c27003ce0c7e322f7d02baff122
Theirs: 4bc04198654971d9190475bbc9bbef8ae3b97aa7
Merge-Strategy: simple-two-way-in-core
Contains-Conflicts: false
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"Change was submitted"}
Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"Change was submitted"}
2026-10-27 12:36:26 -07:00
Gerrit User 1115898
5582173560 Update patch set 1
Patch-set: 1
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: SUBM=+1, 45029f0d634192e5665b2284669bb2ecf44ae3f9
2026-10-27 12:36:26 -07:00
Gerrit User 1347058
bfcfa00a37 Update patch set 1
Patch Set 1:

CV cannot start a Run for `fbarchard@google.com` because the user is neither the CL owner nor a committer.

Patch-set: 1
Tag: autogenerated:cq:full-run:1793129744
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"ps#1: CQ/CV Run failed"}
Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"ps#1: CQ/CV Run failed"}
2026-10-27 12:35:51 -07:00
Gerrit User 1115898
6e62ce83e8 Update patch set 1
Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_1347058> on behalf of <GERRIT_ACCOUNT_1115898>)

Patch-set: 1
Tag: autogenerated:cq:full-run
Label: Commit-Queue=0, b1af4e53067893d40bdaf9c92a8eb2d618bdfce7
Real-user: Gerrit User 1347058 <1347058@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
2026-10-27 12:35:50 -07:00
Gerrit User 1115898
f7d64f7745 Update patch set 1
Patch Set 1: Commit-Queue+2

Patch-set: 1
Label: Commit-Queue=+2, 78b18a618438257aad984a830ee88e9629832d72
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"removed on reply"}
Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"Someone else replied on the change"}
2026-10-27 12:35:44 -07:00
Gerrit User 1347058
48d1375dbd Update patch set 1
Patch Set 1:

CV cannot start a Run for `fbarchard@google.com` because the user is neither the CL owner nor a committer.

Patch-set: 1
Tag: autogenerated:cq:full-run:1793129487
Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"ps#1: CQ/CV Run failed"}
2026-10-27 12:31:33 -07:00
Gerrit User 1115898
543009bc18 Update patch set 1
Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_1347058> on behalf of <GERRIT_ACCOUNT_1115898>)

Patch-set: 1
Tag: autogenerated:cq:full-run
Label: Commit-Queue=0, 9280b68dd4298fbaea9eb410027abc8f0653aec4
Real-user: Gerrit User 1347058 <1347058@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
2026-10-27 12:31:32 -07:00
Gerrit User 1115898
bb540e1df3 Update patch set 1
Patch Set 1: Commit-Queue+2

(1 comment)

Patch-set: 1
Label: Commit-Queue=+2, 75ddd3299f2f279948c2fb35c8ad120ff114ec5a
2026-10-27 12:31:27 -07:00
Gerrit User 1571352
dcc593e16e Update patch set 1
Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1571352\u003e replied on the change"}
2026-10-27 12:30:30 -07:00
Gerrit User 1347058
9ca0111e9d Update patch set 1
Patch Set 1:

CV cannot start a Run for `fbarchard@google.com` because the user is neither the CL owner nor a committer.

Patch-set: 1
Tag: autogenerated:cq:full-run:1793129179
CC: Gerrit User 1347058 <1347058@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"ps#1: CQ/CV Run failed"}
Attention: {"person_ident":"Gerrit User 1571352 \u003c1571352@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"ADD","reason":"ps#1: CQ/CV Run failed"}
2026-10-27 12:26:25 -07:00
Gerrit User 1115898
3e2bea8016 Update patch set 1
Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_1347058> on behalf of <GERRIT_ACCOUNT_1115898>)

Patch-set: 1
Tag: autogenerated:cq:full-run
Label: Commit-Queue=0, 3f26f3762bb0188d5c959dca7b2d7d62348b8850
Real-user: Gerrit User 1347058 <1347058@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
2026-10-27 12:26:23 -07:00
Gerrit User 1115898
93d87baa5f Update patch set 1
Patch Set 1: Commit-Queue+2

Patch-set: 1
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Commit-Queue=+2, 3f84b9be81b66cb9de021f8721895a8172edb566
2026-10-27 12:26:19 -07:00
Gerrit User 1115898
8a1e8189b6 Update patch set 1
Patch Set 1: Code-Review+1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 1115898 <1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Label: Code-Review=+1, d447cf813c556dcbadf8815b8b703380e8373ac3
Attention: {"person_ident":"Gerrit User 1115898 \u003c1115898@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1115898\u003e replied on the change"}
2026-10-27 12:26:11 -07:00

View File

@ -0,0 +1,268 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "855cc898_0b4e2e44",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1115898
},
"writtenOn": "2026-10-27T19:26:11Z",
"side": 1,
"message": "yes this helps a little, but the other lanes are also false dependencies.\nso i think there are 3 alternatives that are better on newer cpus\nzip\nldp\ntbl\nzip1/zip2 depend on load but not each other and no false dependency.\nldp can replace dup and cleanses the register.\nldp can be used to do the transpose itself, either in simd or gpr and can use different registers to avoid the false dependency.\nBut overall I think zip behaves best, with possible exception of A520.",
"revId": "dc630852d7e90c27003ce0c7e322f7d02baff122",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "06b68666_7a6b3e37",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1571352
},
"writtenOn": "2026-10-27T19:30:30Z",
"side": 1,
"message": "well the other lanes are real dependencies, we want the values to be merged :)\n\ni also tried a version using 4x normal vector loads + trn to do the permute but this was slower on a55, so this approach was chosen instead. the big cores don\u0027t seem to mind too much beyond that we break the inter-iteration dependency.",
"parentUuid": "855cc898_0b4e2e44",
"revId": "dc630852d7e90c27003ce0c7e322f7d02baff122",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
},
{
"unresolved": false,
"key": {
"uuid": "842b548f_fa5f01da",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1115898
},
"writtenOn": "2026-10-27T19:31:27Z",
"side": 1,
"message": "btw I did some refactoring of rotate using 8 bit as a basis, making 16 and 32 bit elements work the same way. Instead of \u0027scaling\u0027 to read a column and write a row, a tile is transposed. The transpose is intended to scale with sve or sme, or rvv. avx512/avx/sse are different tile sizes and in practice a common theme emerged - 4 int32 wide by vector length tall as a read, then 4 rows written.\nI\u0027m considering 24 bit, but that may be done a tile wrapper, allowing ld3 to be avoided. on sve, rvv and avx512 masking helps avoid C.",
"revId": "dc630852d7e90c27003ce0c7e322f7d02baff122",
"serverId": "3ce6091f-6c88-37e8-8c75-72f92ae8dfba"
}
],
"submitRequirementResults": [
{
"submitRequirement": {
"name": "Admin-Approval",
"description": {
"value": "Changes to refs/meta/config must be approved by a git admin."
},
"applicabilityExpression": {
"value": {
"expressionString": "branch:refs/meta/config"
}
},
"submittabilityExpression": {
"expressionString": "(uploaderin:mdb/chrome-git-admins OR label:Code-Review\u003dMAX,group\u003dmdb/chrome-git-admins) AND label:Code-Review\u003dMAX,user\u003dnon_uploader AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {
"value": {
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
}
},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"branch:refs/meta/config"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"(uploaderin:mdb/chrome-git-admins OR label:Code-Review=MAX,group=mdb/chrome-git-admins) AND label:Code-Review=MAX,user=non_uploader AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"patchSetCommitId": "dc630852d7e90c27003ce0c7e322f7d02baff122",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Code-Review",
"description": {
"value": "If the author is a libyuv committer, code review is required from one other committer. Otherwise, code review is required from two committers."
},
"applicabilityExpression": {
"value": {
"expressionString": "-branch:refs/meta/config"
}
},
"submittabilityExpression": {
"expressionString": "((uploaderin:cria/project-libyuv-committers AND label:Code-Review\u003dMAX,user\u003dnon_uploader) OR label:Code-Review\u003dMAX,count\u003e\u003d2) AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {
"value": {
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
}
},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"-branch:refs/meta/config"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"((uploaderin:cria/project-libyuv-committers AND label:Code-Review=MAX,user=non_uploader) OR label:Code-Review=MAX,count>=2) AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX,user=non_uploader","uploaderin:cria/project-libyuv-committers","label:Code-Review=MAX,count>=2"],"failingAtoms":["label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Code-Review=MIN":"","label:Code-Review=MAX,user=non_uploader":"","uploaderin:cria/project-libyuv-committers":"","label:Code-Review=MAX,count>=2":""}}}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Bot-Commit=+1","label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Bot-Commit=+1":"","label:Code-Review=MIN":""}}}
},
"patchSetCommitId": "dc630852d7e90c27003ce0c7e322f7d02baff122",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "No-Unresolved-Comments",
"description": {
"value": "Changes that have unresolved comments are not submittable. Unless overridden with Unresolved-Comment-Reason: \u003creason\u003e line in change message."
},
"applicabilityExpression": {
"value": {
"expressionString": "has:unresolved"
}
},
"submittabilityExpression": {
"expressionString": "-has:unresolved"
},
"overrideExpression": {
"value": {
"expressionString": "message:\"^.*Unresolved-Comment-Reason:.*\""
}
},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"],"atomExplanations":{"value":{"has:unresolved":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"message:\"^.*Unresolved-Comment-Reason:.*\""},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"patchSetCommitId": "dc630852d7e90c27003ce0c7e322f7d02baff122",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Review-Enforcement",
"description": {
"value": "Two trusted contributors must approve the change. Uploading the change or voting positively on Code-Review count as approval. For Google employees, using a trusted device is required (http://go/gerrit-onboarding#review-enforcement). For non-Google employees, ReAuth is required (https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gerrit_reauth.md)."
},
"applicabilityExpression": {
"value": {
"expressionString": "is:review-enforced_gerrit"
}
},
"submittabilityExpression": {
"expressionString": "is:review-enforcement-satisfied_gerrit"
},
"overrideExpression": {
"value": {
"expressionString": "NOT label:Code-Review\u003c0 AND is:auto-approval-override-enabled_gerrit"
}
},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforced_gerrit":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforcement-satisfied_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforcement-satisfied_gerrit":"Required approval count satisfied"}}}
},
"overrideExpressionResult": {
"value": {"expression":{"expressionString":"NOT label:Code-Review<0 AND is:auto-approval-override-enabled_gerrit"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:auto-approval-override-enabled_gerrit","label:Code-Review<0"],"atomExplanations":{"value":{"is:auto-approval-override-enabled_gerrit":"","label:Code-Review<0":""}}}
},
"patchSetCommitId": "dc630852d7e90c27003ce0c7e322f7d02baff122",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "SLSA-Policy-Verified",
"description": {
"value": "Verify that binaries are authorized and free from tampering at the configured level."
},
"applicabilityExpression": {
"value": {
"expressionString": "branch:^refs/heads/.* AND is:bcid-exit-gate-applicable_gerrit"
}
},
"submittabilityExpression": {
"expressionString": "label:SLSA-Policy-Verified\u003dMAX\u0026user\u003ddevtools-gerritcodereview-exitgate"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"branch:^refs/heads/.* AND is:bcid-exit-gate-applicable_gerrit"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":["branch:^refs/heads/.*"],"failingAtoms":["is:bcid-exit-gate-applicable_gerrit"],"atomExplanations":{"value":{"branch:^refs/heads/.*":"","is:bcid-exit-gate-applicable_gerrit":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:SLSA-Policy-Verified=MAX&user=devtools-gerritcodereview-exitgate"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {},
"patchSetCommitId": "dc630852d7e90c27003ce0c7e322f7d02baff122",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Verified",
"description": {
"value": "Submit requirement for the \u0027Verified\u0027 label"
},
"applicabilityExpression": {
"value": {
"expressionString": "is:false"
}
},
"submittabilityExpression": {
"expressionString": "is:true"
},
"overrideExpression": {},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"],"atomExplanations":{"value":{"is:false":""}}}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
},
"overrideExpressionResult": {},
"patchSetCommitId": "dc630852d7e90c27003ce0c7e322f7d02baff122",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
}
]
}